* [PATCH v2 1/2] media: zoran: add spaces around '<<'
@ 2021-04-09 18:44 Mitali Borkar
2021-04-09 20:40 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Mitali Borkar @ 2021-04-09 18:44 UTC (permalink / raw)
To: clabbe, mchehab, gregkh
Cc: linux-media, linux-staging, linux-kernel, outreachy-kernel,
mitali_s
No changes required in this patch.
In v1:- Added spaces around '<<' operator to improve readability and meet linux kernel coding
style
Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
---
Changes from v1:- No changes required in this patch. Below is the git
diff of v1.
drivers/staging/media/zoran/zr36057.h | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/media/zoran/zr36057.h b/drivers/staging/media/zoran/zr36057.h
index 71b651add35a..a2a75fd9f535 100644
--- a/drivers/staging/media/zoran/zr36057.h
+++ b/drivers/staging/media/zoran/zr36057.h
@@ -30,13 +30,13 @@
#define ZR36057_VFESPFR_HOR_DCM 14
#define ZR36057_VFESPFR_VER_DCM 8
#define ZR36057_VFESPFR_DISP_MODE 6
-#define ZR36057_VFESPFR_YUV422 (0<<3)
-#define ZR36057_VFESPFR_RGB888 (1<<3)
-#define ZR36057_VFESPFR_RGB565 (2<<3)
-#define ZR36057_VFESPFR_RGB555 (3<<3)
-#define ZR36057_VFESPFR_ERR_DIF (1<<2)
-#define ZR36057_VFESPFR_PACK24 (1<<1)
-#define ZR36057_VFESPFR_LITTLE_ENDIAN (1<<0)
+#define ZR36057_VFESPFR_YUV422 (0 << 3)
+#define ZR36057_VFESPFR_RGB888 (1 << 3)
+#define ZR36057_VFESPFR_RGB565 (2 << 3)
+#define ZR36057_VFESPFR_RGB555 (3 << 3)
+#define ZR36057_VFESPFR_ERR_DIF (1 << 2)
+#define ZR36057_VFESPFR_PACK24 (1 << 1)
+#define ZR36057_VFESPFR_LITTLE_ENDIAN (1 << 0)
#define ZR36057_VDTR 0x00c /* Video Display "Top" Register */
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 1/2] media: zoran: add spaces around '<<'
2021-04-09 18:44 [PATCH v2 1/2] media: zoran: add spaces around '<<' Mitali Borkar
@ 2021-04-09 20:40 ` Julia Lawall
2021-04-09 22:03 ` Mitali Borkar
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2021-04-09 20:40 UTC (permalink / raw)
To: Mitali Borkar
Cc: clabbe, mchehab, gregkh, linux-media, linux-staging, linux-kernel,
outreachy-kernel, mitali_s
On Sat, 10 Apr 2021, Mitali Borkar wrote:
> No changes required in this patch.
> In v1:- Added spaces around '<<' operator to improve readability and meet linux kernel coding
> style
The text above would go in the git history. "No changes required in this
patch." doesn't make sense in that context. If you want to say something
that relates to the history of the submitted patches, then that should be
under the ---. The text there will disappear when the patch is applied.
julia
>
> Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> ---
>
> Changes from v1:- No changes required in this patch. Below is the git
> diff of v1.
>
> drivers/staging/media/zoran/zr36057.h | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/media/zoran/zr36057.h b/drivers/staging/media/zoran/zr36057.h
> index 71b651add35a..a2a75fd9f535 100644
> --- a/drivers/staging/media/zoran/zr36057.h
> +++ b/drivers/staging/media/zoran/zr36057.h
> @@ -30,13 +30,13 @@
> #define ZR36057_VFESPFR_HOR_DCM 14
> #define ZR36057_VFESPFR_VER_DCM 8
> #define ZR36057_VFESPFR_DISP_MODE 6
> -#define ZR36057_VFESPFR_YUV422 (0<<3)
> -#define ZR36057_VFESPFR_RGB888 (1<<3)
> -#define ZR36057_VFESPFR_RGB565 (2<<3)
> -#define ZR36057_VFESPFR_RGB555 (3<<3)
> -#define ZR36057_VFESPFR_ERR_DIF (1<<2)
> -#define ZR36057_VFESPFR_PACK24 (1<<1)
> -#define ZR36057_VFESPFR_LITTLE_ENDIAN (1<<0)
> +#define ZR36057_VFESPFR_YUV422 (0 << 3)
> +#define ZR36057_VFESPFR_RGB888 (1 << 3)
> +#define ZR36057_VFESPFR_RGB565 (2 << 3)
> +#define ZR36057_VFESPFR_RGB555 (3 << 3)
> +#define ZR36057_VFESPFR_ERR_DIF (1 << 2)
> +#define ZR36057_VFESPFR_PACK24 (1 << 1)
> +#define ZR36057_VFESPFR_LITTLE_ENDIAN (1 << 0)
>
> #define ZR36057_VDTR 0x00c /* Video Display "Top" Register */
>
> --
> 2.30.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YHCgksbiLv0pFF2F%40kali.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 1/2] media: zoran: add spaces around '<<'
2021-04-09 20:40 ` [Outreachy kernel] " Julia Lawall
@ 2021-04-09 22:03 ` Mitali Borkar
0 siblings, 0 replies; 3+ messages in thread
From: Mitali Borkar @ 2021-04-09 22:03 UTC (permalink / raw)
To: Julia Lawall
Cc: clabbe, mchehab, gregkh, linux-media, linux-staging, linux-kernel,
outreachy-kernel, mitali_s
On Fri, Apr 09, 2021 at 10:40:25PM +0200, Julia Lawall wrote:
>
>
> On Sat, 10 Apr 2021, Mitali Borkar wrote:
>
> > No changes required in this patch.
> > In v1:- Added spaces around '<<' operator to improve readability and meet linux kernel coding
> > style
>
> The text above would go in the git history. "No changes required in this
> patch." doesn't make sense in that context. If you want to say something
> that relates to the history of the submitted patches, then that should be
> under the ---. The text there will disappear when the patch is applied.
>
Ok Ma'am, I will rectify this mistake and send patch v3 with correct
patch body.
> julia
>
>
> >
> > Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> > ---
> >
> > Changes from v1:- No changes required in this patch. Below is the git
> > diff of v1.
> >
> > drivers/staging/media/zoran/zr36057.h | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/staging/media/zoran/zr36057.h b/drivers/staging/media/zoran/zr36057.h
> > index 71b651add35a..a2a75fd9f535 100644
> > --- a/drivers/staging/media/zoran/zr36057.h
> > +++ b/drivers/staging/media/zoran/zr36057.h
> > @@ -30,13 +30,13 @@
> > #define ZR36057_VFESPFR_HOR_DCM 14
> > #define ZR36057_VFESPFR_VER_DCM 8
> > #define ZR36057_VFESPFR_DISP_MODE 6
> > -#define ZR36057_VFESPFR_YUV422 (0<<3)
> > -#define ZR36057_VFESPFR_RGB888 (1<<3)
> > -#define ZR36057_VFESPFR_RGB565 (2<<3)
> > -#define ZR36057_VFESPFR_RGB555 (3<<3)
> > -#define ZR36057_VFESPFR_ERR_DIF (1<<2)
> > -#define ZR36057_VFESPFR_PACK24 (1<<1)
> > -#define ZR36057_VFESPFR_LITTLE_ENDIAN (1<<0)
> > +#define ZR36057_VFESPFR_YUV422 (0 << 3)
> > +#define ZR36057_VFESPFR_RGB888 (1 << 3)
> > +#define ZR36057_VFESPFR_RGB565 (2 << 3)
> > +#define ZR36057_VFESPFR_RGB555 (3 << 3)
> > +#define ZR36057_VFESPFR_ERR_DIF (1 << 2)
> > +#define ZR36057_VFESPFR_PACK24 (1 << 1)
> > +#define ZR36057_VFESPFR_LITTLE_ENDIAN (1 << 0)
> >
> > #define ZR36057_VDTR 0x00c /* Video Display "Top" Register */
> >
> > --
> > 2.30.2
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YHCgksbiLv0pFF2F%40kali.
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-09 22:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-09 18:44 [PATCH v2 1/2] media: zoran: add spaces around '<<' Mitali Borkar
2021-04-09 20:40 ` [Outreachy kernel] " Julia Lawall
2021-04-09 22:03 ` Mitali Borkar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox