From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01F10C43461 for ; Sat, 10 Apr 2021 12:08:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF3EA611AF for ; Sat, 10 Apr 2021 12:08:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234580AbhDJMIo (ORCPT ); Sat, 10 Apr 2021 08:08:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:57266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231279AbhDJMIn (ORCPT ); Sat, 10 Apr 2021 08:08:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9653C611AF; Sat, 10 Apr 2021 12:08:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618056507; bh=/WH6SBPC+bQg04mE0kmlbX3u2IbS/MY+cappevAC1Zw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cjh7YLusfa6RqhdKrp9QIdy45lk9Rh8Dc3ufuRkcwwcmO1/sWDMIx8AQuX0AHWT02 WN1JwnTUHIytWZIQhSr9PanW9tLX7DESPOxTysGXvorLzJnE2Vbud8ppX/bqZ09H6Q 76gUEy7uT9vkTpxg5nAMisacuL3TQ4o0JwnF/Gv4= Date: Sat, 10 Apr 2021 14:08:24 +0200 From: Greg Kroah-Hartman To: Saravana Kannan Cc: Rob Herring , Ilya Lipnitskiy , Frank Rowand , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , stable Subject: Re: [PATCH v2] of: property: fw_devlink: do not link ".*,nr-gpios" Message-ID: References: <20210405031436.2465475-1-ilya.lipnitskiy@gmail.com> <20210405222540.18145-1-ilya.lipnitskiy@gmail.com> <20210407003408.GA2551507@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 09, 2021 at 12:36:36PM -0700, Saravana Kannan wrote: > On Fri, Apr 9, 2021 at 12:26 PM Rob Herring wrote: > > > > On Wed, Apr 7, 2021 at 3:45 PM Ilya Lipnitskiy > > wrote: > > > > > > On Tue, Apr 6, 2021 at 6:24 PM Saravana Kannan wrote: > > > > > > > > On Tue, Apr 6, 2021 at 6:10 PM Rob Herring wrote: > > > > > > > > > > On Tue, Apr 6, 2021 at 7:46 PM Saravana Kannan wrote: > > > > > > > > > > > > On Tue, Apr 6, 2021 at 5:34 PM Rob Herring wrote: > > > > > > > > > > > > > > On Tue, Apr 06, 2021 at 04:09:10PM -0700, Saravana Kannan wrote: > > > > > > > > On Mon, Apr 5, 2021 at 3:26 PM Ilya Lipnitskiy > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > [,]nr-gpios property is used by some GPIO drivers[0] to indicate > > > > > > > > > the number of GPIOs present on a system, not define a GPIO. nr-gpios is > > > > > > > > > not configured by #gpio-cells and can't be parsed along with other > > > > > > > > > "*-gpios" properties. > > > > > > > > > > > > > > > > > > nr-gpios without the "," prefix is not allowed by the DT > > > > > > > > > spec[1], so only add exception for the ",nr-gpios" suffix and let the > > > > > > > > > error message continue being printed for non-compliant implementations. > > > > > > > > > > > > > > > > > > [0]: nr-gpios is referenced in Documentation/devicetree/bindings/gpio: > > > > > > > > > - gpio-adnp.txt > > > > > > > > > - gpio-xgene-sb.txt > > > > > > > > > - gpio-xlp.txt > > > > > > > > > - snps,dw-apb-gpio.yaml > > > > > > > > > > > > > > > > > > [1]: > > > > > > > > > Link: https://github.com/devicetree-org/dt-schema/blob/cb53a16a1eb3e2169ce170c071e47940845ec26e/schemas/gpio/gpio-consumer.yaml#L20 > > > > > > > > > > > > > > > > > > Fixes errors such as: > > > > > > > > > OF: /palmbus@300000/gpio@600: could not find phandle > > > > > > > > > > > > > > > > > > Fixes: 7f00be96f125 ("of: property: Add device link support for interrupt-parent, dmas and -gpio(s)") > > > > > > > > > Signed-off-by: Ilya Lipnitskiy > > > > > > > > > Cc: Saravana Kannan > > > > > > > > > Cc: # 5.5.x > > > > > > > > > --- > > > > > > > > > drivers/of/property.c | 11 ++++++++++- > > > > > > > > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > > > > > > > > > > > > > > > diff --git a/drivers/of/property.c b/drivers/of/property.c > > > > > > > > > index 2046ae311322..1793303e84ac 100644 > > > > > > > > > --- a/drivers/of/property.c > > > > > > > > > +++ b/drivers/of/property.c > > > > > > > > > @@ -1281,7 +1281,16 @@ DEFINE_SIMPLE_PROP(pinctrl7, "pinctrl-7", NULL) > > > > > > > > > DEFINE_SIMPLE_PROP(pinctrl8, "pinctrl-8", NULL) > > > > > > > > > DEFINE_SUFFIX_PROP(regulators, "-supply", NULL) > > > > > > > > > DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells") > > > > > > > > > -DEFINE_SUFFIX_PROP(gpios, "-gpios", "#gpio-cells") > > > > > > > > > + > > > > > > > > > +static struct device_node *parse_gpios(struct device_node *np, > > > > > > > > > + const char *prop_name, int index) > > > > > > > > > +{ > > > > > > > > > + if (!strcmp_suffix(prop_name, ",nr-gpios")) > > > > > > > > > + return NULL; > > > > > > > > > > > > > > > > Ah I somehow missed this patch. This gives a blanked exception for > > > > > > > > vendor,nr-gpios. I'd prefer explicit exceptions for all the instances > > > > > > > > of ",nr-gpios" we are grandfathering in. Any future additions should > > > > > > > > be rejected. Can we do that please? > > > > > > > > > > > > > > > > Rob, you okay with making this list more explicit? > > > > > > > > > > > > > > Not the kernel's job IMO. A schema is the right way to handle that. > > > > > > > > > > > > Ok, that's fine by me. Btw, let's land this in driver-core? I've made > > > > > > changes there and this might cause conflicts. Not sure. > > > > > > > > > > It merges with linux-next fine. You'll need to resend this to Greg if > > > > > you want to do that. > > > > > > > > > > Reviewed-by: Rob Herring > > > > > > > > Hi Greg, > > > > > > > > Can you pull this into driver-core please? > > > Do you want me to re-spin on top of driver-core? The patch is > > > currently based on dt/next in robh/linux.git > > > > I did say you need to resend the patch to Greg, but since there's no > > movement on this and I have other things to send upstream, I've > > applied it. > > :'( > > If it's not too late, can we please drop it? I'm sure Greg would be > okay with picking this up. It's in Linus's tree, why does it matter who sends it in? {sigh}