Re: [PATCH] staging: rtl8723bs: remove unnecessary goto jumps

Greg Kroah-Hartman
2021-04-10T13:36:32Z

On Sat, Apr 10, 2021 at 01:33:09PM +0000, Bryan Brattlof wrote:
> The next instruction for both 'goto exit' jump statements is to
> execute the exit jump instructions regardless. We can safely
> remove all jump statements from __init rtw_drv_entry()
>
> Signed-off-by: Bryan Brattlof <hello@bryanbrattlof.com>
> ---
> drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> index 9fd926e1698f..84ac81d19746 100644
> --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> @@ -517,13 +517,9 @@ static int __init rtw_drv_entry(void)
> if (ret != 0) {
> sdio_drvpriv.drv_registered = false;
> rtw_ndev_notifier_unregister();
> - goto exit;
> }
>
> - goto exit;
> -
> -exit:
> - DBG_871X_LEVEL(_drv_always_, "module init ret =%d\n", ret);
> + DBG_870X_LEVEL(_drv_always_, "module init ret =%d\n", ret);

Why did you change this line?

thanks,

greg k-h