From: Mitali Borkar <mitaliborkar810@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com, mitali_s@me.iitr.ac.in
Subject: Re: [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'
Date: Sat, 10 Apr 2021 19:07:08 +0530 [thread overview]
Message-ID: <YHGqBLS+IcHdkI6r@kali> (raw)
In-Reply-To: <YHGksKltkkmaUeAk@kroah.com>
On Sat, Apr 10, 2021 at 03:14:24PM +0200, Greg KH wrote:
> On Sat, Apr 10, 2021 at 06:30:38PM +0530, Mitali Borkar wrote:
> > Fixed Comparison to NULL can be written as '!...' by replacing it with
> > simpler form i.e. boolean expression. This makes code more readable
> > alternative.
> > Reported by checkpatch.
>
> Checkpatch did not report this specific problem, Julia did :)
>
> And this changelog text does not reflect the commit you made here.
>
Making the changes now.
> >
> > Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
>
> We need a "Reported-by:" line here to reflect that someone reported the
> problem as well.
>
I am resending this as patch v3. I have to add reprted by Julia, right?
> Ideally it will have a "Fixes:" tag also, but I can add that if you
> don't know how to do that just yet.
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2021-04-10 13:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 13:00 [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*' Mitali Borkar
2021-04-10 13:14 ` Greg KH
2021-04-10 13:37 ` Mitali Borkar [this message]
2021-04-10 13:48 ` Greg KH
2021-04-10 13:23 ` [Outreachy kernel] " Julia Lawall
2021-04-10 13:26 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHGqBLS+IcHdkI6r@kali \
--to=mitaliborkar810@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mitali_s@me.iitr.ac.in \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox