public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Fabio Aiuto <fabioaiuto83@gmail.com>
Cc: julia.lawall@inria.fr, joe@perches.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] staging: rtl8723bs: put a new line after ';'
Date: Wed, 14 Apr 2021 10:25:40 +0200	[thread overview]
Message-ID: <YHanBPRxVVfoOb5p@kroah.com> (raw)
In-Reply-To: <7e796fe7a5a370d055be201204dcac14f09c974a.1618325614.git.fabioaiuto83@gmail.com>

On Tue, Apr 13, 2021 at 04:56:33PM +0200, Fabio Aiuto wrote:
> fix the following post commit hook checkpatch issue:
> 
> ERROR: space required after that ';' (ctx:VxV)
> 232: FILE: drivers/staging/rtl8723bs/core/rtw_odm.c:160:
> +		   "AdapEn_RSSI", "IGI_LowerBound");netdev_dbg
> 			(adapter->pnetdev,
> 
> This was coccinelle script output coding style issue.
> 
> Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_odm.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_odm.c b/drivers/staging/rtl8723bs/core/rtw_odm.c
> index 084f6ae040ee..f4a0ef428564 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_odm.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_odm.c
> @@ -157,14 +157,15 @@ void rtw_odm_adaptivity_parm_msg(void *sel, struct adapter *adapter)
>  
>  	netdev_dbg(adapter->pnetdev, "%10s %16s %8s %10s %11s %14s\n",
>  		   "TH_L2H_ini", "TH_EDCCA_HL_diff", "IGI_Base", "ForceEDCCA",
> -		   "AdapEn_RSSI", "IGI_LowerBound");netdev_dbg(adapter->pnetdev,
> -							       "0x%-8x %-16d 0x%-6x %-10d %-11u %-14u\n",
> -							       (u8)odm->TH_L2H_ini,
> -							       odm->TH_EDCCA_HL_diff,
> -							       odm->IGI_Base,
> -							       odm->ForceEDCCA,
> -							       odm->AdapEn_RSSI,
> -							       odm->IGI_LowerBound);
> +		   "AdapEn_RSSI", "IGI_LowerBound");
> +	netdev_dbg(adapter->pnetdev,
> +		   "0x%-8x %-16d 0x%-6x %-10d %-11u %-14u\n",
> +		   (u8)odm->TH_L2H_ini,
> +		   odm->TH_EDCCA_HL_diff,
> +		   odm->IGI_Base,
> +		   odm->ForceEDCCA,
> +		   odm->AdapEn_RSSI,
> +		   odm->IGI_LowerBound);
>  }
>  
>  void rtw_odm_adaptivity_parm_set(struct adapter *adapter, s8 TH_L2H_ini,
> -- 
> 2.20.1

This patch should not be needed, your commit that caused this error
should not have done so.  Please fix that instead.

thanks,

greg k-h

  reply	other threads:[~2021-04-14  8:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 14:56 [PATCH 0/7] staging: rtl8723bs: replace DBG_871X_SEL_NL macro with netdev_dbg() Fabio Aiuto
2021-04-13 14:56 ` [PATCH 1/7] staging: rtl8723bs: replace dump_drv_version() usage " Fabio Aiuto
2021-04-13 14:56 ` [PATCH 2/7] staging: rtl8723bs: remove unnecessary dump_drv_version() usage Fabio Aiuto
2021-04-13 14:56 ` [PATCH 3/7] staging: rtl8723bs: remove two unused functions Fabio Aiuto
2021-04-13 14:56 ` [PATCH 4/7] staging: rtl8723bs: replace DBG_871X_SEL_NL with netdev_dbg() Fabio Aiuto
2021-04-14  8:26   ` Greg KH
2021-04-14  9:43     ` Fabio Aiuto
2021-04-14 10:28       ` Greg KH
2021-04-13 14:56 ` [PATCH 5/7] staging: rtl8723bs: put a new line after ';' Fabio Aiuto
2021-04-14  8:25   ` Greg KH [this message]
2021-04-13 14:56 ` [PATCH 6/7] staging: rtl8723bs: remove DBG_871X_SEL_NL macro declaration Fabio Aiuto
2021-04-13 14:56 ` [PATCH 7/7] staging: rtl8723bs: remove unused argument in function Fabio Aiuto
  -- strict thread matches above, loose matches on Subject: below --
2021-04-13 14:10 [PATCH 0/7] staging: rtl8723bs: replace DBG_871X_SEL_NL macro with netdev_dbg() Fabio Aiuto
2021-04-13 14:10 ` [PATCH 5/7] staging: rtl8723bs: put a new line after ';' Fabio Aiuto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHanBPRxVVfoOb5p@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=fabioaiuto83@gmail.com \
    --cc=joe@perches.com \
    --cc=julia.lawall@inria.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox