From: Peter Zijlstra <peterz@infradead.org>
To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.comi>, Mel Gorman <mgorman@suse.de>,
Len Brown <len.brown@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Aubrey Li <aubrey.li@linux.intel.com>,
"Ravi V. Shankar" <ravi.v.shankar@intel.com>,
Ricardo Neri <ricardo.neri@intel.com>,
Quentin Perret <qperret@google.com>,
"Joel Fernandes (Google)" <joel@joelfernandes.org>,
linux-kernel@vger.kernel.org, Aubrey Li <aubrey.li@intel.com>,
Ben Segall <bsegall@google.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>
Subject: Re: [PATCH v2 3/4] sched/fair: Consider SMT in ASYM_PACKING load balance
Date: Mon, 3 May 2021 12:02:49 +0200 [thread overview]
Message-ID: <YI/KSfWuGLhPnilr@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20210414020436.12980-4-ricardo.neri-calderon@linux.intel.com>
On Tue, Apr 13, 2021 at 07:04:35PM -0700, Ricardo Neri wrote:
> @@ -8507,6 +8616,18 @@ static bool update_sd_pick_busiest(struct lb_env *env,
> if (!sgs->sum_h_nr_running)
> return false;
>
> + /*
> + * @sg may have been tentatively classified as group_asym_packing.
> + * Now that we have sufficient information about @sds.local, reassess
> + * if asym packing migration can be done. Reclassify @sg. The only
> + * possible results are group_has_spare and group_fully_busy.
> + */
> + if (sgs->group_type == group_asym_packing &&
> + !asym_can_pull_tasks(env->dst_cpu, sds, sgs, sg)) {
> + sgs->group_asym_packing = 0;
> + sgs->group_type = group_classify(env->sd->imbalance_pct, sg, sgs);
> + }
So if this really is all about not having sds.local in
update_sd_lb_stats(), then that seems fixable. Let me haz a try.
next prev parent reply other threads:[~2021-05-03 10:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 2:04 [PATCH v2 0/4] sched/fair: Fix load balancing of SMT siblings with ASYM_PACKING Ricardo Neri
2021-04-14 2:04 ` [PATCH v2 1/4] sched/fair: Optimize checking for group_asym_packing Ricardo Neri
2021-05-03 9:24 ` Peter Zijlstra
2021-05-04 3:08 ` Ricardo Neri
2021-04-14 2:04 ` [PATCH v2 2/4] sched/fair: Introduce arch_sched_asym_prefer_early() Ricardo Neri
2021-04-14 2:04 ` [PATCH v2 3/4] sched/fair: Consider SMT in ASYM_PACKING load balance Ricardo Neri
2021-05-03 9:52 ` Peter Zijlstra
2021-05-06 4:28 ` Ricardo Neri
2021-05-06 9:17 ` Peter Zijlstra
2021-05-03 9:54 ` Peter Zijlstra
2021-05-03 10:02 ` Peter Zijlstra [this message]
2021-05-03 10:23 ` Peter Zijlstra
2021-05-04 3:09 ` Ricardo Neri
2021-05-06 4:26 ` Ricardo Neri
2021-05-06 9:18 ` Peter Zijlstra
2021-04-14 2:04 ` [PATCH v2 4/4] x86/sched: Enable checks of the state of SMT siblings in load balancing Ricardo Neri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YI/KSfWuGLhPnilr@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aubrey.li@intel.com \
--cc=aubrey.li@linux.intel.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=bsegall@google.comi \
--cc=dietmar.eggemann@arm.com \
--cc=joel@joelfernandes.org \
--cc=juri.lelli@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=qperret@google.com \
--cc=ravi.v.shankar@intel.com \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=ricardo.neri@intel.com \
--cc=rostedt@goodmis.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox