From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6CDCC433B4 for ; Mon, 3 May 2021 10:03:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 699D3611AB for ; Mon, 3 May 2021 10:03:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233212AbhECKET (ORCPT ); Mon, 3 May 2021 06:04:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233152AbhECKET (ORCPT ); Mon, 3 May 2021 06:04:19 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 449F3C06174A for ; Mon, 3 May 2021 03:03:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mLUoHUuU4w0ObYVm7U+TfjHFuEYtZIhN4dWr35/0b9g=; b=H5UxfVHIXv1eRkUSEtMvsIBZkj p2JIOoZ76y9unNZYRgJbgAGipjJW6rIgq6NSE+oxq7PJM8dTiPV9YJrM+YK1INrIv8aN4PYmoUm/k 6DtCPTtkiXXXRsiFlCSihB9QRp7eR11YrvRdAY1oHPAAZJz+8wiCuUl6+bCEgXTPq3HbS6TS2RwP/ 0/8+Vvx4kSq0WMHyjcbWtqypKxprBpLeDM4SktRD5v84kfEg5gVy3lSZXRQtejciNpgd7unZ7qkGU GCmrjuBAqgLK0fv2sSdvpv3QFJ3rRrat/eZOXyVAE5OeUVqBIo2IxDWgRh+MhPEJvmCypXrJSyPiX FSDNEP1g==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1ldVPd-00Dc7r-Vy; Mon, 03 May 2021 10:02:53 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 3DEBD3001D0; Mon, 3 May 2021 12:02:49 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 1ED052BC22568; Mon, 3 May 2021 12:02:49 +0200 (CEST) Date: Mon, 3 May 2021 12:02:49 +0200 From: Peter Zijlstra To: Ricardo Neri Cc: Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Len Brown , Srinivas Pandruvada , Tim Chen , Aubrey Li , "Ravi V. Shankar" , Ricardo Neri , Quentin Perret , "Joel Fernandes (Google)" , linux-kernel@vger.kernel.org, Aubrey Li , Ben Segall , Daniel Bristot de Oliveira Subject: Re: [PATCH v2 3/4] sched/fair: Consider SMT in ASYM_PACKING load balance Message-ID: References: <20210414020436.12980-1-ricardo.neri-calderon@linux.intel.com> <20210414020436.12980-4-ricardo.neri-calderon@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210414020436.12980-4-ricardo.neri-calderon@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 13, 2021 at 07:04:35PM -0700, Ricardo Neri wrote: > @@ -8507,6 +8616,18 @@ static bool update_sd_pick_busiest(struct lb_env *env, > if (!sgs->sum_h_nr_running) > return false; > > + /* > + * @sg may have been tentatively classified as group_asym_packing. > + * Now that we have sufficient information about @sds.local, reassess > + * if asym packing migration can be done. Reclassify @sg. The only > + * possible results are group_has_spare and group_fully_busy. > + */ > + if (sgs->group_type == group_asym_packing && > + !asym_can_pull_tasks(env->dst_cpu, sds, sgs, sg)) { > + sgs->group_asym_packing = 0; > + sgs->group_type = group_classify(env->sd->imbalance_pct, sg, sgs); > + } So if this really is all about not having sds.local in update_sd_lb_stats(), then that seems fixable. Let me haz a try.