From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7959C43460 for ; Mon, 3 May 2021 12:14:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94C13611C2 for ; Mon, 3 May 2021 12:14:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233557AbhECMPX (ORCPT ); Mon, 3 May 2021 08:15:23 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50796 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229594AbhECMPW (ORCPT ); Mon, 3 May 2021 08:15:22 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1ldXSt-002Hrd-A5; Mon, 03 May 2021 14:14:19 +0200 Date: Mon, 3 May 2021 14:14:19 +0200 From: Andrew Lunn To: LABBE Corentin Cc: Rob Herring , hkallweit1@gmail.com, linux@armlinux.org.uk, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v3] dt-bindings: net: Convert mdio-gpio to yaml Message-ID: References: <20210430182941.915101-1-clabbe@baylibre.com> <20210430215325.GA3957879@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > What's the order with 3 lines? In any case, define the order with > > schema: > > > > minItems: > > items: > > - description: MDC signal > > - description: MDIO or ?? signal > > - description: ?? signal > > > > I dont know what to write in the third line, I added the "maxItems: 3" by request of Andrew Lunn. > But I have no example at hand. > > Andrew could you give me an example of: "You often find with x86 machines you don't have GPIOs, just GPI > and GPO, and you need to combine two to form the MDIO line of the MDIO bus." > Or could I drop the "maxItems: 3" until a board need it. The code gets the GPIOs via index. The index are defined in include/linux/gpio-mdio.h as: #define MDIO_GPIO_MDC 0 #define MDIO_GPIO_MDIO 1 #define MDIO_GPIO_MDO 2 So you can describe them MDC, MDIO, MDO. Andrew