From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DBEAC433ED for ; Mon, 3 May 2021 12:49:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FED4611C9 for ; Mon, 3 May 2021 12:49:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233793AbhECMud (ORCPT ); Mon, 3 May 2021 08:50:33 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50860 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233757AbhECMuc (ORCPT ); Mon, 3 May 2021 08:50:32 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1ldY10-002I5N-GK; Mon, 03 May 2021 14:49:34 +0200 Date: Mon, 3 May 2021 14:49:34 +0200 From: Andrew Lunn To: Ansuel Smith Cc: Florian Fainelli , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH net-next v2 02/17] net: mdio: ipq8064: switch to write/readl function Message-ID: References: <20210502230710.30676-1-ansuelsmth@gmail.com> <20210502230710.30676-2-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210502230710.30676-2-ansuelsmth@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 03, 2021 at 01:06:54AM +0200, Ansuel Smith wrote: > Use readl/writel function instead of regmap function to make sure no > value is cached and align to other similar mdio driver. regmap is O.K. to use, so long as you tell it not to cache. Look at how to use volatile in regmap. You might be able to follow what lan9303_mdio.c is doing. Andrew