public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ashish Kalra <eashishkalra@gmail.com>
Cc: Ivan Safonov <insafonov@gmail.com>,
	Abheek Dhawan <adawesomeguy222@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Waiman Long <longman@redhat.com>,
	Pritthijit Nath <pritthijit.nath@icloud.com>,
	Allen Pais <apais@linux.microsoft.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces)
Date: Sat, 1 May 2021 14:23:12 +0200	[thread overview]
Message-ID: <YI1IMG8tCvvRMq3i@kroah.com> (raw)
In-Reply-To: <YI098DQNtK3i2Fge@ashish-NUC8i5BEH>

On Sat, May 01, 2021 at 05:09:28PM +0530, Ashish Kalra wrote:
> Currently p80211knetdev_do_ioctl use type casting to req->data to prevent sparse warning while calling memdup_user, instead of type casting it here, its better to change data type for data inside p80211ioctl_req to include __user.

Please properly line-wrap your changelog comments.

Can you fix it up and resend it as v3?

thanks,

greg k-h

  reply	other threads:[~2021-05-01 12:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-01 11:39 [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces) Ashish Kalra
2021-05-01 12:23 ` Greg Kroah-Hartman [this message]
2021-05-01 13:54   ` Ashish
  -- strict thread matches above, loose matches on Subject: below --
2021-04-27 18:03 Ashish Kalra
2021-04-27 17:22 Ashish Kalra
2021-04-27 16:58 Ashish Kalra
2021-04-28  6:02 ` Greg Kroah-Hartman
2021-04-27 18:04   ` ashish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YI1IMG8tCvvRMq3i@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=adawesomeguy222@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=apais@linux.microsoft.com \
    --cc=eashishkalra@gmail.com \
    --cc=insafonov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=longman@redhat.com \
    --cc=pritthijit.nath@icloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox