From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62BD1C433ED for ; Sat, 1 May 2021 12:23:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3372261409 for ; Sat, 1 May 2021 12:23:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232021AbhEAMYI (ORCPT ); Sat, 1 May 2021 08:24:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:51806 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231960AbhEAMYF (ORCPT ); Sat, 1 May 2021 08:24:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 83BB361409; Sat, 1 May 2021 12:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619871795; bh=IsCKUsoaFkNF0OuX9NN16ruS+Rs+wIjJ1sC465dv+ss=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VrUvaZIIpBrfM8muwRro4KSxyB0Mzsqk01yyP6fxljWk+3gydENOCBECUqia5mQ5z PeImyO+f4Kw4I8A8+ye3FWfwyC+x00NkBXCFj/8kzuQx1UHYtriIwDtR0SVy32So4h bnRXLZi8T4FRwUZQqCbOOZnZO4iu3f7vsGkt4/Go= Date: Sat, 1 May 2021 14:23:12 +0200 From: Greg Kroah-Hartman To: Ashish Kalra Cc: Ivan Safonov , Abheek Dhawan , Andrew Morton , Waiman Long , Pritthijit Nath , Allen Pais , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces) Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 01, 2021 at 05:09:28PM +0530, Ashish Kalra wrote: > Currently p80211knetdev_do_ioctl use type casting to req->data to prevent sparse warning while calling memdup_user, instead of type casting it here, its better to change data type for data inside p80211ioctl_req to include __user. Please properly line-wrap your changelog comments. Can you fix it up and resend it as v3? thanks, greg k-h