From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dejin Zheng <zhengdejin5@gmail.com>
Cc: corbet@lwn.net, jarkko.nikula@linux.intel.com,
mika.westerberg@linux.intel.com, rric@kernel.org,
bhelgaas@google.com, wsa@kernel.org, linux-doc@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/4] Introduce pcim_alloc_irq_vectors()
Date: Wed, 21 Apr 2021 18:23:23 +0300 [thread overview]
Message-ID: <YIBDa1bvKInOg2LH@smile.fi.intel.com> (raw)
In-Reply-To: <20210226155056.1068534-1-zhengdejin5@gmail.com>
On Fri, Feb 26, 2021 at 11:50:52PM +0800, Dejin Zheng wrote:
> Introduce pcim_alloc_irq_vectors(), a device-managed version of
> pci_alloc_irq_vectors(), In some i2c drivers, If pcim_enable_device()
> has been called before, then pci_alloc_irq_vectors() is actually a
> device-managed function. It is used as a device-managed function, So
> replace it with pcim_alloc_irq_vectors().
Bjorn, I don't see this anywhere, except mailing list. Neither your opinion.
What is the plan?
> Changelog
> ---------
> v4 -> v5:
> - Remove the check of enable device in pcim_alloc_irq_vectors()
> and make it as a static line function.
> - Modify the subject name in patch 3 and patch 4.
> v3 -> v4:
> - add some commit comments for patch 3
> v2 -> v3:
> - Add some commit comments for replace some codes in
> pcim_release() by pci_free_irq_vectors().
> - Simplify the error handling path in i2c designware
> driver.
> v1 -> v2:
> - Use pci_free_irq_vectors() to replace some code in
> pcim_release().
> - Modify some commit messages.
>
> Dejin Zheng (4):
> PCI: Introduce pcim_alloc_irq_vectors()
> Documentation: devres: Add pcim_alloc_irq_vectors()
> i2c: designware: Use pcim_alloc_irq_vectors() to allocate IRQ vectors
> i2c: thunderx: Use pcim_alloc_irq_vectors() to allocate IRQ vectors
>
> .../driver-api/driver-model/devres.rst | 1 +
> drivers/i2c/busses/i2c-designware-pcidrv.c | 15 ++++--------
> drivers/i2c/busses/i2c-thunderx-pcidrv.c | 2 +-
> drivers/pci/pci.c | 5 +---
> include/linux/pci.h | 24 +++++++++++++++++++
> 5 files changed, 31 insertions(+), 16 deletions(-)
>
> --
> 2.25.0
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-04-21 15:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 15:50 [PATCH v5 0/4] Introduce pcim_alloc_irq_vectors() Dejin Zheng
2021-02-26 15:50 ` [PATCH v5 1/4] PCI: " Dejin Zheng
2021-02-26 16:23 ` Andy Shevchenko
2021-02-28 11:16 ` Dejin Zheng
2021-03-23 22:47 ` Bjorn Helgaas
2021-05-05 16:27 ` Dejin Zheng
2021-06-02 8:51 ` Andy Shevchenko
2021-06-06 6:51 ` Dejin Zheng
2021-06-07 16:15 ` Bjorn Helgaas
2021-02-26 15:50 ` [PATCH v5 2/4] Documentation: devres: Add pcim_alloc_irq_vectors() Dejin Zheng
2021-02-26 15:50 ` [PATCH v5 3/4] i2c: designware: Use pcim_alloc_irq_vectors() to allocate IRQ vectors Dejin Zheng
2021-03-03 9:27 ` Jarkko Nikula
2021-02-26 15:50 ` [PATCH v5 4/4] i2c: thunderx: " Dejin Zheng
2021-02-26 19:19 ` Robert Richter
2021-02-26 19:20 ` [PATCH v5 0/4] Introduce pcim_alloc_irq_vectors() Robert Richter
2021-02-28 11:17 ` Dejin Zheng
2021-04-21 15:23 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIBDa1bvKInOg2LH@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rric@kernel.org \
--cc=wsa@kernel.org \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox