public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: b-liu@ti.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
Subject: Re: [PATCH] usb: musb: davinci: change the variable type
Date: Thu, 22 Apr 2021 10:49:10 +0200	[thread overview]
Message-ID: <YIE4hh5NOJMT7QqK@kroah.com> (raw)
In-Reply-To: <20210418183618.GA69452@user>

On Mon, Apr 19, 2021 at 12:06:18AM +0530, Saurav Girepunje wrote:
> vbus_state is define as bool but on davinci.c assigning a value
> '-1' to the bool variable.

Does it also test that value?

If so, shouldn't that logic error be fixed instead of working around it
by changing the variable type?

This feels wrong...

thanks,

greg k-h

  reply	other threads:[~2021-04-22  8:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-18 18:36 [PATCH] usb: musb: davinci: change the variable type Saurav Girepunje
2021-04-22  8:49 ` Greg KH [this message]
2021-04-27 19:37   ` SAURAV GIREPUNJE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIE4hh5NOJMT7QqK@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=b-liu@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=saurav.girepunje@gmail.com \
    --cc=saurav.girepunje@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox