From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF62DC43460 for ; Thu, 22 Apr 2021 12:45:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B5FB610E6 for ; Thu, 22 Apr 2021 12:45:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236346AbhDVMqX (ORCPT ); Thu, 22 Apr 2021 08:46:23 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:35658 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236144AbhDVMqW (ORCPT ); Thu, 22 Apr 2021 08:46:22 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lZYiD-000UwN-Aq; Thu, 22 Apr 2021 14:45:41 +0200 Date: Thu, 22 Apr 2021 14:45:41 +0200 From: Andrew Lunn To: Prasanna Vengateshan Cc: netdev@vger.kernel.org, olteanv@gmail.com, robh+dt@kernel.org, UNGLinuxDriver@microchip.com, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, vivien.didelot@gmail.com, f.fainelli@gmail.com, devicetree@vger.kernel.org Subject: Re: [PATCH v2 net-next 2/9] net: phy: Add support for LAN937x T1 phy driver Message-ID: References: <20210422094257.1641396-1-prasanna.vengateshan@microchip.com> <20210422094257.1641396-3-prasanna.vengateshan@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210422094257.1641396-3-prasanna.vengateshan@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +#define PORT_T1_PHY_RESET BIT(15) > +#define PORT_T1_PHY_LOOPBACK BIT(14) > +#define PORT_T1_SPEED_100MBIT BIT(13) > +#define PORT_T1_POWER_DOWN BIT(11) > +#define PORT_T1_ISOLATE BIT(10) > +#define PORT_T1_FULL_DUPLEX BIT(8) These appear to be standard BMCR_ values. Please don't define your own. > + > +#define REG_PORT_T1_PHY_BASIC_STATUS 0x01 > + > +#define PORT_T1_MII_SUPPRESS_CAPABLE BIT(6) > +#define PORT_T1_LINK_STATUS BIT(2) > +#define PORT_T1_EXTENDED_CAPABILITY BIT(0) > + > +#define REG_PORT_T1_PHY_ID_HI 0x02 > +#define REG_PORT_T1_PHY_ID_LO 0x03 MII_PHYSID1 and MII_PHYSID2 Please go through all these #defines and replace them with the standard ones Linux provides. You are obfusticating the code by not using what people already know. Andrew