From: Roman Gushchin <guro@fb.com>
To: Vasily Averin <vvs@virtuozzo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@kernel.org>
Subject: Re: [PATCH] tools/cgroup/slabinfo.py: updated to work on current kernel
Date: Thu, 22 Apr 2021 17:52:52 -0700 [thread overview]
Message-ID: <YIIaZEPdnmXbSMgL@carbon> (raw)
In-Reply-To: <cec1a75e-43b4-3d64-2084-d9f98fda037f@virtuozzo.com>
On Thu, Apr 22, 2021 at 08:29:31AM +0300, Vasily Averin wrote:
> slabinfo.py script does not work with actual kernel version.
> First, it was unable to recognise SLUB susbsytem,
> when I specified it manually, it was failed again with
> AttributeError: 'struct page' has no member 'obj_cgroups'
> ... and then again with
> File "tools/cgroup/memcg_slabinfo.py", line 221, in main
> memcg.kmem_caches.address_of_(),
> AttributeError: 'struct mem_cgroup' has no member 'kmem_caches'
>
> Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Indeed, we forgot to update it after recent changes in page->memcg_data.
Thank you, Vasily, for updating it!
I tested it, and it works great for me. Please, feel free to add
Tested-by: Roman Gushchin <guro@fb.com>
Acked-by: Roman Gushchin <guro@fb.com>
Thanks!
prev parent reply other threads:[~2021-04-23 0:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 5:29 [PATCH] tools/cgroup/slabinfo.py: updated to work on current kernel Vasily Averin
2021-04-23 0:52 ` Roman Gushchin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIIaZEPdnmXbSMgL@carbon \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox