From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5223C433ED for ; Fri, 23 Apr 2021 13:08:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 991FB6145F for ; Fri, 23 Apr 2021 13:08:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242614AbhDWNIr (ORCPT ); Fri, 23 Apr 2021 09:08:47 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:37968 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242646AbhDWNId (ORCPT ); Fri, 23 Apr 2021 09:08:33 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lZvXD-000elp-OF; Fri, 23 Apr 2021 15:07:51 +0200 Date: Fri, 23 Apr 2021 15:07:51 +0200 From: Andrew Lunn To: "Radu Pirea (NXP OSS)" Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: nxp-c45-tja11xx: add interrupt support Message-ID: References: <20210423124329.993850-1-radu-nicolae.pirea@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210423124329.993850-1-radu-nicolae.pirea@oss.nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static irqreturn_t nxp_c45_handle_interrupt(struct phy_device *phydev) > +{ > + irqreturn_t ret = IRQ_NONE; > + int irq; > + > + irq = phy_read_mmd(phydev, MDIO_MMD_VEND1, VEND1_PHY_IRQ_STATUS); > + if (irq & PHY_IRQ_LINK_EVENT) { > + phy_trigger_machine(phydev); > + phy_write_mmd(phydev, MDIO_MMD_VEND1, VEND1_PHY_IRQ_ACK, > + PHY_IRQ_LINK_EVENT); The ordering here is interesting. Could phy_trigger_machine() cause a second interrupt? Which you then clear without acting upon before exiting the interrupt handler? I think you should ACK the interrupt before calling phy_trigger_machine(). Andrew