From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Stephen Boyd <swboyd@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, Jessica Yu <jeyu@kernel.org>,
Evan Green <evgreen@chromium.org>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-doc@vger.kernel.org, Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v5 05/13] module: Add printk formats to add module build ID to stacktraces
Date: Fri, 23 Apr 2021 17:08:41 +0300 [thread overview]
Message-ID: <YILU6R0OMUXo3wA7@smile.fi.intel.com> (raw)
In-Reply-To: <dabbab72-7534-66e2-21e1-6e0005bdc2d7@rasmusvillemoes.dk>
On Fri, Apr 23, 2021 at 03:45:56PM +0200, Rasmus Villemoes wrote:
> On 23/04/2021 15.24, Andy Shevchenko wrote:
> > On Thu, Apr 22, 2021 at 04:46:40PM -0700, Stephen Boyd wrote:
>
> >>>> +#include <linux/kernel.h>
> >>>
> >>> What do you need this header for?
> >>>
> >>
> >> For typeof_member().
> >
> > Argh... We really need to split this and container_of to something else. Having
> > entire kernel.h for that is an overkill.
> >
>
> Yeah, we should have a type-macros.h (or type-helpers or whatever) that
> doesn't include any other kernel headers, just stddef.h (which is
> compiler-provided) for offsetof(), providing
>
> typeof_member
> sizeof_member
> container_of
> same_type
> type_min
> type_max
> is_signed_type
> __choose_type
>
> or whatever their names are currently.
Put in my TODO list. Not sure when it will go, though.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-04-23 14:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 21:49 [PATCH v5 00/13] Add build ID to stacktraces Stephen Boyd
2021-04-20 21:49 ` [PATCH v5 01/13] buildid: Only consider GNU notes for build ID parsing Stephen Boyd
2021-04-20 21:49 ` [PATCH v5 02/13] buildid: Add API to parse build ID out of buffer Stephen Boyd
2021-04-20 21:49 ` [PATCH v5 03/13] buildid: Stash away kernels build ID on init Stephen Boyd
2021-04-28 10:02 ` Baoquan He
2021-04-20 21:49 ` [PATCH v5 04/13] dump_stack: Add vmlinux build ID to stack traces Stephen Boyd
2021-04-26 11:04 ` Petr Mladek
2021-04-26 23:40 ` Stephen Boyd
2021-04-20 21:49 ` [PATCH v5 05/13] module: Add printk formats to add module build ID to stacktraces Stephen Boyd
2021-04-21 11:49 ` Andy Shevchenko
2021-04-22 23:46 ` Stephen Boyd
2021-04-23 13:24 ` Andy Shevchenko
2021-04-23 13:45 ` Rasmus Villemoes
2021-04-23 14:08 ` Andy Shevchenko [this message]
2021-04-26 23:42 ` Stephen Boyd
2021-04-20 21:49 ` [PATCH v5 06/13] arm64: stacktrace: Use %pSb for backtrace printing Stephen Boyd
2021-04-21 9:58 ` Catalin Marinas
2021-04-20 21:49 ` [PATCH v5 07/13] x86/dumpstack: Use %pSb/%pBb " Stephen Boyd
2021-04-20 21:49 ` [PATCH v5 08/13] scripts/decode_stacktrace.sh: Support debuginfod Stephen Boyd
2021-04-20 21:49 ` [PATCH v5 09/13] scripts/decode_stacktrace.sh: Silence stderr messages from addr2line/nm Stephen Boyd
2021-04-20 21:50 ` [PATCH v5 10/13] scripts/decode_stacktrace.sh: Indicate 'auto' can be used for base path Stephen Boyd
2021-04-20 21:50 ` [PATCH v5 11/13] buildid: Mark some arguments const Stephen Boyd
2021-04-20 21:50 ` [PATCH v5 12/13] buildid: Fix kernel-doc notation Stephen Boyd
2021-04-20 21:50 ` [PATCH v5 13/13] kdump: Use vmlinux_build_id to simplify Stephen Boyd
2021-04-28 10:13 ` Baoquan He
2021-04-28 23:14 ` Stephen Boyd
2021-05-07 3:54 ` Baoquan He
2021-05-07 4:04 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YILU6R0OMUXo3wA7@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=evgreen@chromium.org \
--cc=hsinyi@chromium.org \
--cc=jeyu@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=swboyd@chromium.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox