From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2BCCC433ED for ; Fri, 23 Apr 2021 17:30:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BEA8861410 for ; Fri, 23 Apr 2021 17:30:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243237AbhDWRaz (ORCPT ); Fri, 23 Apr 2021 13:30:55 -0400 Received: from mga06.intel.com ([134.134.136.31]:28650 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbhDWRay (ORCPT ); Fri, 23 Apr 2021 13:30:54 -0400 IronPort-SDR: HH7J0U3oyCG414KCwiaIxEOQyMXv+p9cFG6DYK4E5+h2aU8d1QQruvQA6r6eBU7Soh+EylEHoJ 6Z2IKDtw2CbA== X-IronPort-AV: E=McAfee;i="6200,9189,9963"; a="257411468" X-IronPort-AV: E=Sophos;i="5.82,246,1613462400"; d="scan'208";a="257411468" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 10:30:16 -0700 IronPort-SDR: H9+pJ0RnWOxq95zAbxojlapA9H16lEreXz5ioaDa6GiMX0Jc7ksJcaW+a51sLjX3NXrGLdTt9x Yd6R36OQH8PA== X-IronPort-AV: E=Sophos;i="5.82,246,1613462400"; d="scan'208";a="386443849" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 10:30:11 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lZzd2-006cKS-BS; Fri, 23 Apr 2021 20:30:08 +0300 Date: Fri, 23 Apr 2021 20:30:08 +0300 From: Andy Shevchenko To: Mark Brown Cc: Cezary Rojewski , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, alsa-devel@alsa-project.org, Dmitry Torokhov , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , Jaroslav Kysela , Takashi Iwai Subject: Re: [PATCH v1 05/14] spi: pxa2xx: Consolidate related headers under include/linux/spi Message-ID: References: <20210423163437.89306-1-andriy.shevchenko@linux.intel.com> <20210423163437.89306-5-andriy.shevchenko@linux.intel.com> <20210423165630.GH5507@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210423165630.GH5507@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 23, 2021 at 05:56:30PM +0100, Mark Brown wrote: > On Fri, Apr 23, 2021 at 07:34:28PM +0300, Andy Shevchenko wrote: > > > We have two headers split between include/linux and include/linux/spi. > > Consolidated them under SPI realm, i.e. in the latter folder. > > Why? Isn't the point to maintain an abstraction between the general > purpose use of the SSP IP and its application as a SPI controller? Aren't the General Purpose of the SSP IP is an SPI controller either way? What you are talking about is probably GP SPI vs. private (dedicated) SPI. But okay, I got the idea, I can drop this patch. > I'd > check the cover letter for the series but there doesn't seem to be one. Set of cleanups here and there related to the SPI PXA2xx driver. It's hard to add something else here. -- With Best Regards, Andy Shevchenko