Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices

Valdis Klētnieks
2021-04-24T20:38:04Z

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

On Sun, 25 Apr 2021 01:13:01 +0530, Anupama K Patil said:
> Changed sprintf() to the kernel-space function scnprintf() as it returns
> the actual number of bytes written.

> + if (!bus->procdir) {
> + scnprintf(name, 16, "%02x", bus->number);

> + scnprintf(name, 16, "%02x", dev->number);

Why do this when you don't *use* the number of bytes written, but instead ignore
the value returned?

For bonus points: Given the %02x format, under what conditions can it
return a value other than 2?

[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]