From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 275ECC433ED for ; Tue, 27 Apr 2021 11:53:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EEF0C613E2 for ; Tue, 27 Apr 2021 11:53:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235952AbhD0Lyd (ORCPT ); Tue, 27 Apr 2021 07:54:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:58240 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230365AbhD0Lyc (ORCPT ); Tue, 27 Apr 2021 07:54:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F37AA600D1; Tue, 27 Apr 2021 11:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619524429; bh=zOdZ8wsIcX3Guq2MFUQ/w40b2my/1WULT2eP1PNk4Bg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A7c/hbXp8yGMKstemc0QqvdbEhnzJ9mGyE6fvOBDQxryclaFChFbrXPdxSbXmfgnm 02Z9mcTprm+IU46UcRHOkzIpNw+N72o3XD35BZdqh88xHpHbOmqXPWEIvcq/X0pPkX xZMi05zCse6QPmyQ+TGxtVUFCu32xrx2f5kXKMeU= Date: Tue, 27 Apr 2021 13:53:46 +0200 From: Greg Kroah-Hartman To: Hans de Goede Cc: linux-kernel@vger.kernel.org, Aditya Pakki , Mukesh Ojha Subject: Re: [PATCH 114/190] Revert "staging: rtl8188eu: Fix potential NULL pointer dereference of kcalloc" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-115-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 06:55:59PM +0200, Hans de Goede wrote: > Hi, > > On 4/21/21 2:59 PM, Greg Kroah-Hartman wrote: > > This reverts commit 7671ce0d92933762f469266daf43bd34d422d58c. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > Cc: Aditya Pakki > > Cc: Mukesh Ojha > > Cc: Hans de Goede > > Cc: Greg Kroah-Hartman > > Signed-off-by: Greg Kroah-Hartman > > FWIW the original commit seems fine here. So if that is an option please > drop this revert from the set. Revert is now dropped, thanks for looking at it. greg k-h