From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1078FC433ED for ; Tue, 27 Apr 2021 13:11:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8E0F613DD for ; Tue, 27 Apr 2021 13:11:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236121AbhD0NLx (ORCPT ); Tue, 27 Apr 2021 09:11:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:47804 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235489AbhD0NLt (ORCPT ); Tue, 27 Apr 2021 09:11:49 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3D7A2613C8; Tue, 27 Apr 2021 13:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619529065; bh=eF35Tnf4PiV35XLj7Xf7zsuZaAaaflmqarwD/osrkgI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BtvmdxHFkqWNNUX9yA+8ZO4dcjQxlP1pIsX9tZpDGGfSE0TAX3MrsEaTkH/A0dHtT 53X0k+ZcOkIR0r28SJYVc7j1Rl2L27wLStFHGnsRYvGbdYCQ/hYsmCJ26JGWSLoMip QL0gIw/FOBD7z95Us7miJzeSkVBTq8FKoe1h7oks= Date: Tue, 27 Apr 2021 15:11:03 +0200 From: Greg Kroah-Hartman To: Hans Verkuil Cc: linux-kernel@vger.kernel.org, Qiushi Wu , Mauro Carvalho Chehab , "Rafael J. Wysocki" , Pavel Machek Subject: Re: [PATCH 007/190] Revert "media: ti-vpe: Fix a missing check and reference count leak" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-8-gregkh@linuxfoundation.org> <01927b51-7d17-112a-a0fd-eae3efafd769@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01927b51-7d17-112a-a0fd-eae3efafd769@xs4all.nl> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 22, 2021 at 10:10:50AM +0200, Hans Verkuil wrote: > On 21/04/2021 14:58, Greg Kroah-Hartman wrote: > > This reverts commit 7dae2aaaf432767ca7aa11fa84643a7c2600dbdd. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > Cc: Qiushi Wu > > Cc: Hans Verkuil > > Cc: Mauro Carvalho Chehab > > Signed-off-by: Greg Kroah-Hartman > > --- > > drivers/media/platform/ti-vpe/vpe.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c > > index 10251b787674..c7a0a7c19ca6 100644 > > --- a/drivers/media/platform/ti-vpe/vpe.c > > +++ b/drivers/media/platform/ti-vpe/vpe.c > > @@ -2473,8 +2473,6 @@ static int vpe_runtime_get(struct platform_device *pdev) > > > > r = pm_runtime_get_sync(&pdev->dev); > > WARN_ON(r < 0); > > - if (r) > > This should have been: if (r < 0) > > I missed that as a reviewer, and I don't think it was intentional either > since I couldn't find any clear documentation in pm_runtime_get_sync() > that it can return 0 or 1 as success. After going through a few wrapper > functions you end up in rpm_resume() in drivers/base/power/runtime.c > which doesn't document the return code. > > So keep this reverted and I'll make a new patch for this later. > > I've CC-ed Rafael and Pavel: it would be really nice if someone can > document the return code from rpm_resume() in drivers/base/power/runtime.c. > > I just discovered that it is documented in Documentation/power/runtime_pm.rst, > but if you just look at the code then you'll miss this. Mauro asked for me to drop this one, as he's fixing them all up in a "better" way with a follow-on patch series. thanks, greg k-h