From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01508C433ED for ; Tue, 27 Apr 2021 14:28:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C74AB611ED for ; Tue, 27 Apr 2021 14:28:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237412AbhD0O3i (ORCPT ); Tue, 27 Apr 2021 10:29:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:41810 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236395AbhD0O3g (ORCPT ); Tue, 27 Apr 2021 10:29:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CF0F4611ED; Tue, 27 Apr 2021 14:28:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619533732; bh=qguW6x5iRS4Xzu5FMCao6iMXdBvVld/tXB0kl4A2XkE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AKsF0yyMHuiB3Vq/q8SkQKdeoLxp9RY9ux991eX3+BCPREFryNAB2+oeVaX4y+P0z B7q2nJa1n0Bt6DUFiElEjC/0kmTWxAny1tTLOs/El8WZq83tYc3WR031NVSCTtgSDP ruD+WjS6D5MXp7inP+rmDQ58k9OwMekR7WtkWXu0= Date: Tue, 27 Apr 2021 16:28:50 +0200 From: Greg Kroah-Hartman To: Devesh Sharma Cc: Jason Gunthorpe , LKML , Aditya Pakki Subject: Re: [PATCH 166/190] Revert "infiniband: bnxt_re: qplib: Check the return value of send_message" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-167-gregkh@linuxfoundation.org> <20210421140844.GI1370958@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 07:45:34PM +0530, Devesh Sharma wrote: > On Wed, Apr 21, 2021 at 7:38 PM Jason Gunthorpe wrote: > > > > On Wed, Apr 21, 2021 at 03:00:41PM +0200, Greg Kroah-Hartman wrote: > > > This reverts commit 94edd87a1c59f3efa6fdf4e98d6d492e6cec6173. > > > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > > faith" to try to test the kernel community's ability to review "known > > > malicious" changes. The result of these submissions can be found in a > > > paper published at the 42nd IEEE Symposium on Security and Privacy > > > entitled, "Open Source Insecurity: Stealthily Introducing > > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > > > Because of this, all submissions from this group must be reverted from > > > the kernel tree and will need to be re-reviewed again to determine if > > > they actually are a valid fix. Until that work is complete, remove this > > > change to ensure that no problems are being introduced into the > > > codebase. > > > > > > Cc: Aditya Pakki > > > Cc: Devesh Sharma > > > Cc: Jason Gunthorpe > > > Signed-off-by: Greg Kroah-Hartman > > > --- > > > drivers/infiniband/hw/bnxt_re/qplib_sp.c | 5 +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > Can't see a reason to revert this one, I re-checked the callers error > > paths and it looks OK > > > > Jason > Acked-By: Devesh Sharma Thanks for the review, I'll drop this as the original looks ok for now. greg k-h