From: Johan Hovold <johan@kernel.org>
To: Sanjana Srinidhi <sanjanasrinidhi1810@gmail.com>
Cc: linux@dominikbrodowski.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix indentation of block comments
Date: Thu, 29 Apr 2021 11:28:50 +0200 [thread overview]
Message-ID: <YIp8UnL4big41DdL@hovoldconsulting.com> (raw)
In-Reply-To: <20210429085532.djej2ko2dttertt5@sanjana-VirtualBox>
On Thu, Apr 29, 2021 at 02:25:32PM +0530, Sanjana Srinidhi wrote:
> Trailing */ of block comments is moved to a new line to maintain code uniformity.
>
> Signed-off-by: Sanjana Srinidhi <sanjanasrinidhi1810@gmail.com>
> ---
> drivers/pcmcia/soc_common.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pcmcia/soc_common.c b/drivers/pcmcia/soc_common.c
> index 98b6d96a4435..7a88bd9bd4ed 100644
> --- a/drivers/pcmcia/soc_common.c
> +++ b/drivers/pcmcia/soc_common.c
> @@ -28,7 +28,8 @@
> the provisions above, a recipient may use your version of this
> file under either the MPL or the GPL.
>
> -======================================================================*/
> +======================================================================
> +*/
These kind of "cleanups" are mostly pointless and amount to nothing more
than noise.
Please consider working in drivers/staging/ which currently works as
some sort of learning-ground for new contributors instead if you really
want to send these kind of patches.
Johan
prev parent reply other threads:[~2021-04-29 9:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 8:55 [PATCH] Fix indentation of block comments Sanjana Srinidhi
2021-04-29 9:28 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIp8UnL4big41DdL@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=sanjanasrinidhi1810@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox