From: Johan Hovold <johan@kernel.org>
To: Tung Pham <Tung.Pham@silabs.com>
Cc: Pho Tran <photranvan0712@gmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Hung Nguyen <Hung.Nguyen@silabs.com>,
Pho Tran <Pho.Tran@silabs.com>
Subject: Re: [PATCH v9] USB: serial: cp210x: Add support for GPIOs on CP2108
Date: Thu, 29 Apr 2021 08:55:18 +0200 [thread overview]
Message-ID: <YIpYVk0bwIXFyAuE@hovoldconsulting.com> (raw)
In-Reply-To: <CO1PR11MB4882A90461E033F8EA301C07815F9@CO1PR11MB4882.namprd11.prod.outlook.com>
On Thu, Apr 29, 2021 at 02:54:09AM +0000, Tung Pham wrote:
> So my questions again are:
>
> 1) Have you verified that the struct cp210x_quad_port_config above
> actually matches what the device uses?
>
> 2) Do you have any documentation of the structures as expected by the
> device firmware (not your library)?
>
>
> Tung Pham: the device return some unused bytes, and manufacturing
> library already discard these byte to assign value to PORT_CONFIG, so
> you don't see padding byte on PORT_CONFIG structure. you can find
> the structure of port setting in this code:
>
> https://www.silabs.com/documents/public/software/USBXpressHostSDK-Linux.tar
>
>
> \USBXpressHostSDK-Linux\USBXpressHostSDK\CP210x\srcpkg\cp210xmanufacturing_1.0.tar\cp210xmanufacturing_1.0\cp210xmanufacturing\cp210xmanufacturing\src\CP2104Device.cpp
>
> CP210x_STATUS CCP2104Device::GetPortConfig(PORT_CONFIG* PortConfig)
Thanks for confirming.
Johan
prev parent reply other threads:[~2021-04-29 6:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 10:36 [PATCH v9] USB: serial: cp210x: Add support for GPIOs on CP2108 Pho Tran
2021-04-19 15:42 ` Johan Hovold
2021-04-21 14:52 ` Johan Hovold
2021-04-26 9:49 ` Tung Pham
2021-04-28 9:36 ` Johan Hovold
2021-04-29 2:54 ` Tung Pham
2021-04-29 6:55 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIpYVk0bwIXFyAuE@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=Hung.Nguyen@silabs.com \
--cc=Pho.Tran@silabs.com \
--cc=Tung.Pham@silabs.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=photranvan0712@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox