From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4420DC43462 for ; Fri, 30 Apr 2021 16:56:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 226A26145A for ; Fri, 30 Apr 2021 16:56:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231134AbhD3Q5K (ORCPT ); Fri, 30 Apr 2021 12:57:10 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:48256 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229750AbhD3Q5C (ORCPT ); Fri, 30 Apr 2021 12:57:02 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lcWQw-001q8G-Hb; Fri, 30 Apr 2021 18:56:06 +0200 Date: Fri, 30 Apr 2021 18:56:06 +0200 From: Andrew Lunn To: Randy Dunlap Cc: Oleksij Rempel , Shawn Guo , Sascha Hauer , Florian Fainelli , Heiner Kallweit , Fugang Duan , Geert Uytterhoeven , kernel@pengutronix.de, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, Fabio Estevam , David Jander , Russell King , Philippe Schenker Subject: Re: [PATCH net-next v1 1/1] net: selftest: provide option to disable generic selftests Message-ID: References: <20210430095308.14465-1-o.rempel@pengutronix.de> <20210430154153.zhdnxzkm2fhcuogo@pengutronix.de> <6865cd7a-7f2e-13f5-a588-8877d771b834@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6865cd7a-7f2e-13f5-a588-8877d771b834@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 30, 2021 at 09:33:42AM -0700, Randy Dunlap wrote: > On 4/30/21 9:23 AM, Andrew Lunn wrote: > >>> Thanks for the patch/option. But I think it should just default to n, > >>> not PHYLIB. > >> > >> It should be enabled by default for every device supporting this kind of > >> selftests. > > > > I agree. > > > > I still wonder if there is confusion about self test here. Maybe > > Probably. > > > putting ethtool into the description will help people understand it > > has nothing to do with the kernel self test infrastructure and kernel > > self testing. > > So it's a hardware check that is required to be run if it's implemented > in a driver? > > Required by who/what? It is not required, but it is a useful debug tool for the educated user. Root can run the self tests on the network interface. If the self test pass, but the interface does not work, you probably have a cabling or configuration issue. Networking is complex and being able to eliminate the interface hardware lets you concentrate on some other part of the problem. You can then maybe next use the cable test option of ethtool to see if the cable has a problem. Andrew