From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14303C433ED for ; Thu, 13 May 2021 13:59:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CECB76127A for ; Thu, 13 May 2021 13:59:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234265AbhEMOA2 (ORCPT ); Thu, 13 May 2021 10:00:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:34930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234125AbhEMOAQ (ORCPT ); Thu, 13 May 2021 10:00:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D8093613CB; Thu, 13 May 2021 13:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620914345; bh=9HPOfeqNsiShUm9j8FOh3mdJ/VHgroUuF5wEuIfb1mU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EQifcfF3NHO5xPsMTxCcdylPC9aa8VQ0MRzkik3maWbQ/p/TzHaYRDx5zV2UMU+hB 7M/L6D7u0uZ/sob6Ve+gQvKn0g2YgKmt782/5m3Nhx4tDyxRz/337kiI9Wi3ZgXZxJ QAX8Tm87DSMt5pxgT/XTVF+2ewJDLjsnFZp2DXHo= Date: Thu, 13 May 2021 15:59:03 +0200 From: Greg KH To: Zou Wei Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] USB: EHCI: ehci-mv: add missing MODULE_DEVICE_TABLE Message-ID: References: <1620801369-18642-1-git-send-email-zou_wei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1620801369-18642-1-git-send-email-zou_wei@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 12, 2021 at 02:36:09PM +0800, Zou Wei wrote: > This patch adds missing MODULE_DEVICE_TABLE definition which generates > correct modalias for automatic loading of this driver when it is built > as an external module. > > Reported-by: Hulk Robot > Signed-off-by: Zou Wei > --- > drivers/usb/host/ehci-mv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c > index cffdc8d..beb478c 100644 > --- a/drivers/usb/host/ehci-mv.c > +++ b/drivers/usb/host/ehci-mv.c > @@ -266,6 +266,7 @@ static const struct platform_device_id ehci_id_table[] = { > {"pxa-sph", 0}, > {}, > }; > +MODULE_DEVICE_TABLE(platform, ehci_id_table); As I said elsewhere, I'm not taking these unless you can show a reason why they are needed. thanks, greg k-h