From: Shreyansh Chouhan <chouhan.shreyansh630@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
pure.logic@nexus-software.ie, johan@kernel.org, elder@kernel.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: fix gb_loopback_stats_attrs definition
Date: Fri, 14 May 2021 23:34:48 +0530 [thread overview]
Message-ID: <YJ67wCBVnI21YbUc@fedora> (raw)
In-Reply-To: <bccbec1a0ffbf6c31b5e6a78cedd78cd64f2b8fe.camel@perches.com>
On Fri, May 14, 2021 at 08:56:10AM -0700, Joe Perches wrote:
> On Fri, 2021-05-14 at 17:30 +0200, Greg KH wrote:
> > On Fri, May 14, 2021 at 08:42:16PM +0530, Shreyansh Chouhan wrote:
> []
> > > I didn't look at how/where was the macro called and missed a very
> > > obvious error. Now that I have looked at it, the only way I can think of
> > > fixing this is changing the macro to a (inline?) function. Will
> > > that be a desirable change?
> >
> > No, it can't be a function, the code is fine as-is, checkpatch is just a
> > perl script and does not always know what needs to be done.
>
> true.
>
> perhaps better though to rename these declaring macros to start with declare_
>
> Something like this:
>
Can I mention you in the 'Suggested-by' tag for the commit? (Since you
suggested the idea for this patch.)
Regards,
Shreyansh Chouhan
next prev parent reply other threads:[~2021-05-14 18:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 13:30 [PATCH] staging: greybus: fix gb_loopback_stats_attrs definition Shreyansh Chouhan
2021-05-14 13:36 ` Greg KH
2021-05-14 13:48 ` Shreyansh Chouhan
2021-05-14 14:05 ` Greg KH
2021-05-14 14:23 ` Shreyansh Chouhan
2021-05-14 14:30 ` Greg KH
2021-05-14 15:12 ` Shreyansh Chouhan
2021-05-14 15:30 ` Greg KH
2021-05-14 15:34 ` Shreyansh Chouhan
2021-05-14 15:56 ` Joe Perches
2021-05-14 16:51 ` Shreyansh Chouhan
2021-05-14 18:04 ` Shreyansh Chouhan [this message]
2021-05-14 18:53 ` Alex Elder
2021-05-14 19:07 ` Shreyansh Chouhan
2021-05-14 19:32 ` Joe Perches
2021-05-14 19:40 ` Shreyansh Chouhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJ67wCBVnI21YbUc@fedora \
--to=chouhan.shreyansh630@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=joe@perches.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox