From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CEBBC433B4 for ; Fri, 14 May 2021 14:24:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FCF961457 for ; Fri, 14 May 2021 14:24:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234389AbhENOZT (ORCPT ); Fri, 14 May 2021 10:25:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233485AbhENOZQ (ORCPT ); Fri, 14 May 2021 10:25:16 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07623C061574 for ; Fri, 14 May 2021 07:24:03 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id m190so24263511pga.2 for ; Fri, 14 May 2021 07:24:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sjqOcTYhx7FLkQmHt5WpgoQOTVEbNARnsInkpqxUIFw=; b=hA/MVEdbUU+zFmvDEr5zcjB8z7tOFUNCYzvBiqsVL0nh7NxoYJ/wp12KuGN0eZlNDb uMsvelfIWSHF+kpXnDBImyPvpiRGW0PqQLu4PR7P/epoG5JaXCkROCyZ6UAG+/TULes7 WzuYq++5cLktampH8blX+EqVD8OowfwxtHY3xKWWwyCyHcwhH1qDp2gvYCMZ9SGaNsOZ WUcQhXxB2doyp7XJqfZPOxD4ydXHKfcC+Q2e3rdcc6AaYYx94eLmnD4tXBlhtECr/hCM H5G7P8TzpI2VW0OgeIaWBYsOc7GjCqWF43QTCxpKbhXtI7PELsDqSjEdg5K8+lU+zvfP Qkbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sjqOcTYhx7FLkQmHt5WpgoQOTVEbNARnsInkpqxUIFw=; b=E9NCPHd1ziWR6+tpokmiWiA7gfdX/j2xsn06FSqPz0oicY5vrkC2QVV4sSHyxUf1pK igcn5zW3v32s29hp9udSQAWWtqnY1ketoIxN8ZXOWmkboxd5pUIjOu7jdnQthEP5M9t/ a8CM664Jk1na1bm9nUXqgaE/QwoYF1CPpRKdfE5wgKLLQKnvCOhAABaYJaHPbWC4jR0L GDUE3lJTGrusgaaTo/amcEp5mk6d33OcmHzBCd3WQWKqriw3knWu00a1NCR0bAhd37ZW dj+oVTzthoVjllMDQYnswlpYZsMqbkyG+tQ7+LNHo3YTWmNIXpdEBVIIvJ5Oi+mDfVsE 5+IA== X-Gm-Message-State: AOAM531QCnqA7ranTauCGTC9Ubj4+EIMvCxHY5JBk+tuDAKNODvTJ/UU PuGx9OttsXhvoBpkKcDRXjw= X-Google-Smtp-Source: ABdhPJwZxndpiXExilm+A8RkJakXbSgnMJ6SlOqS/vi81wdoEdrGz7YRVKPfvpaN9WsDSPUH5+3Qnw== X-Received: by 2002:a63:4610:: with SMTP id t16mr46631158pga.171.1621002243300; Fri, 14 May 2021 07:24:03 -0700 (PDT) Received: from fedora ([2405:201:6008:61b4:4e16:5348:d963:c66d]) by smtp.gmail.com with ESMTPSA id u12sm4130975pfh.122.2021.05.14.07.23.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 May 2021 07:24:02 -0700 (PDT) Date: Fri, 14 May 2021 19:53:57 +0530 From: Shreyansh Chouhan To: Greg KH Cc: pure.logic@nexus-software.ie, johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: fix gb_loopback_stats_attrs definition Message-ID: References: <20210514133039.304760-1-chouhan.shreyansh630@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 14, 2021 at 04:05:32PM +0200, Greg KH wrote: > On Fri, May 14, 2021 at 07:18:38PM +0530, Shreyansh Chouhan wrote: > > On Fri, May 14, 2021 at 03:36:25PM +0200, Greg KH wrote: > > > On Fri, May 14, 2021 at 07:00:39PM +0530, Shreyansh Chouhan wrote: > > > > The gb_loopback_stats_attrs macro, (defined in loopback.c,) is a > > > > multiline macro whose statements were not enclosed in a do while > > > > loop. > > > > > > > > This patch adds a do while loop around the statements of the said > > > > macro. > > > > > > > > Signed-off-by: Shreyansh Chouhan > > > > --- > > > > drivers/staging/greybus/loopback.c | 10 ++++++---- > > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c > > > > index 2471448ba42a..c88ef3e894fa 100644 > > > > --- a/drivers/staging/greybus/loopback.c > > > > +++ b/drivers/staging/greybus/loopback.c > > > > @@ -162,10 +162,12 @@ static ssize_t name##_avg_show(struct device *dev, \ > > > > } \ > > > > static DEVICE_ATTR_RO(name##_avg) > > > > > > > > -#define gb_loopback_stats_attrs(field) \ > > > > - gb_loopback_ro_stats_attr(field, min, u); \ > > > > - gb_loopback_ro_stats_attr(field, max, u); \ > > > > - gb_loopback_ro_avg_attr(field) > > > > +#define gb_loopback_stats_attrs(field) \ > > > > + do { \ > > > > + gb_loopback_ro_stats_attr(field, min, u); \ > > > > + gb_loopback_ro_stats_attr(field, max, u); \ > > > > + gb_loopback_ro_avg_attr(field); \ > > > > + } while (0) > > > > > > > > #define gb_loopback_attr(field, type) \ > > > > static ssize_t field##_show(struct device *dev, \ > > > > -- > > > > 2.31.1 > > > > > > > > > > > > > > Did you test build this change? > > > > I built the module using make -C . M=drivers/staging/greybus to test > > build it. I didn't get any errors. > > Really? Can you provide the full build output for this file with your > change? I don't think you really built this file for the obvious > reasons... I ran make -C . M=drivers/staging/greybus I got a three line output saying: make: Entering directory '/work/linux' MODPOST drivers/staging/greybus//Module.symvers make: Leaving directory '/work/linux' I just tried rebuilding the kernel with CONFIG_GREYBUS=m, and now I can see what you are talking about. Why weren't these errors reported when I ran the previous make command? Does that too check for the config variables even when I specifically asked it to build a module? Also sorry about this. I will be more careful next time. > > thanks, > > greg k-h Regards, Shreyansh Chouhan