From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A20DBC433ED for ; Thu, 6 May 2021 09:04:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7247E6121F for ; Thu, 6 May 2021 09:04:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233989AbhEFJFS (ORCPT ); Thu, 6 May 2021 05:05:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:40196 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233765AbhEFJFR (ORCPT ); Thu, 6 May 2021 05:05:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 50434611AD; Thu, 6 May 2021 09:04:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620291859; bh=t5kO1RsBj6L282zo2Irz4ki0RAdod79K0nlUviJ0DRY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dr53OI1jURTtSScsXd57eUQ9+2gsxRRQ5HE8nSaQjtxPiDpLi1OUYk3IfWGj50WeL lsxXsfBKQNaS+YCt6aFGYEhLMDYppmMkoj2RghPGPa9dOnlYwDgW/Z1iB+QG4vmW4s Gk/1EOtZD7f4bze/Q7+pGvLY54pEPJ7s5rcpoS/0Hn4AkRYbBEge0u0HX+ubH1kQz6 Df12ZMnE4yAi3Tu3O9pFA/CxKkD3QLThxqeUZqxdIyCRbmUhgELaVBHyoi4xl7yE1L 9vqEGnKxBguWG2hgrXUaAhazZeSSIw595UkjoOy1VFO9RLIBgREWYGb/Yu4+PiIKR6 VMaEA2aSKQD0w== Date: Thu, 6 May 2021 12:04:14 +0300 From: Leon Romanovsky To: Xiaofei Tan Cc: jgg@ziepe.ca, liweihang@huawei.com, liangwenpeng@huawei.com, shiju.jose@huawei.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@openeuler.org Subject: Re: [PATCH] RDMA/ucma: Cleanup to reduce duplicate code Message-ID: References: <1620291106-3675-1-git-send-email-tanxiaofei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1620291106-3675-1-git-send-email-tanxiaofei@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 06, 2021 at 04:51:46PM +0800, Xiaofei Tan wrote: > The lable "err1" does the same thing as the branch of copy_to_user() > failed in the function ucma_create_id(). Just jump to the label directly > to reduce duplicate code. > > Signed-off-by: Xiaofei Tan > --- > drivers/infiniband/core/ucma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky