* Re: [PATCH] Input: ili210x - add missing negation for touch indication on ili210x [not found] <DS7PR19MB44212FCE6607B2C7978AB612DD589@DS7PR19MB4421.namprd19.prod.outlook.com> @ 2021-05-06 17:50 ` Marek Vasut [not found] ` <DS7PR19MB442159ACE7E2C03013917956DD589@DS7PR19MB4421.namprd19.prod.outlook.com> 0 siblings, 1 reply; 2+ messages in thread From: Marek Vasut @ 2021-05-06 17:50 UTC (permalink / raw) To: Hansem Ro, linux-input; +Cc: linux-kernel, dmitry.torokhov On 5/6/21 7:32 PM, Hansem Ro wrote: > This adds the negation needed for proper finger detection on Ilitek > ili2107/ili210x. This fixes the polling and coordinate parsing issues > (on Amazon Kindle Fire) caused by returning false for the cooresponding > finger on the touchscreen. > > Signed-off-by: Hansem Ro <hansemro@outlook.com> > --- > drivers/input/touchscreen/ili210x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/ili210x.c b/drivers/input/touchscreen/ili210x.c > index d8fccf048bf4..30576a5f2f04 100644 > --- a/drivers/input/touchscreen/ili210x.c > +++ b/drivers/input/touchscreen/ili210x.c > @@ -87,7 +87,7 @@ static bool ili210x_touchdata_to_coords(const u8 *touchdata, > unsigned int *x, unsigned int *y, > unsigned int *z) > { > - if (touchdata[0] & BIT(finger)) > + if (!(touchdata[0] & BIT(finger))) This makes the behavior consistent with the other ILI21xx touchscreen controllers too, so I think this patch is OK, thanks. It would be nice if you could add Fixes: tag, so this could get picked into linux-stable too. ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <DS7PR19MB442159ACE7E2C03013917956DD589@DS7PR19MB4421.namprd19.prod.outlook.com>]
* Re: [PATCH v2] Input: ili210x - add missing negation for touch indication on ili210x [not found] ` <DS7PR19MB442159ACE7E2C03013917956DD589@DS7PR19MB4421.namprd19.prod.outlook.com> @ 2021-05-06 20:29 ` Dmitry Torokhov 0 siblings, 0 replies; 2+ messages in thread From: Dmitry Torokhov @ 2021-05-06 20:29 UTC (permalink / raw) To: Hansem Ro; +Cc: marex, mjsakellaropoulos, linux-input, linux-kernel On Thu, May 06, 2021 at 12:38:19PM -0700, Hansem Ro wrote: > This adds the negation needed for proper finger detection on Ilitek > ili2107/ili210x. This fixes polling issues (on Amazon Kindle Fire) > caused by returning false for the cooresponding finger on the touchscreen. > > Signed-off-by: Hansem Ro <hansemro@outlook.com> > Fixes: e3559442afd2a ("ili210x - rework the touchscreen sample processing") Applied, thank you. -- Dmitry ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-06 20:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <DS7PR19MB44212FCE6607B2C7978AB612DD589@DS7PR19MB4421.namprd19.prod.outlook.com>
2021-05-06 17:50 ` [PATCH] Input: ili210x - add missing negation for touch indication on ili210x Marek Vasut
[not found] ` <DS7PR19MB442159ACE7E2C03013917956DD589@DS7PR19MB4421.namprd19.prod.outlook.com>
2021-05-06 20:29 ` [PATCH v2] " Dmitry Torokhov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox