From: Eric Biggers <ebiggers@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: reduce expensive checkpoint trigger frequency
Date: Thu, 6 May 2021 23:33:25 -0700 [thread overview]
Message-ID: <YJTfNeYeDT65GslB@sol.localdomain> (raw)
In-Reply-To: <20210425011053.44436-1-yuchao0@huawei.com>
On Sun, Apr 25, 2021 at 09:10:53AM +0800, Chao Yu wrote:
> + if (!error && S_ISDIR(inode->i_mode) && f2fs_encrypted_file(inode) &&
> + f2fs_is_checkpointed_node(sbi, inode->i_ino))
> + f2fs_add_ino_entry(sbi, inode->i_ino, ENC_DIR_INO);
This will never be true, since S_ISDIR() and f2fs_encrypted_file() are logically
contradictory (as f2fs_encrypted_file() only returns true when S_ISREG()).
How did you test this change?
- Eric
next prev parent reply other threads:[~2021-05-07 6:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 1:10 [PATCH v2] f2fs: reduce expensive checkpoint trigger frequency Chao Yu
2021-04-26 17:09 ` Jaegeuk Kim
2021-04-27 2:56 ` Chao Yu
2021-05-04 14:36 ` Jaegeuk Kim
2021-05-06 2:15 ` Chao Yu
2021-05-06 4:43 ` Jaegeuk Kim
2021-05-06 6:27 ` Chao Yu
2021-05-10 15:36 ` Jaegeuk Kim
2021-05-11 1:33 ` Chao Yu
2021-05-07 6:33 ` Eric Biggers [this message]
2021-05-07 6:52 ` [f2fs-dev] " Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJTfNeYeDT65GslB@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox