From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D61B0C433ED for ; Sat, 8 May 2021 23:20:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE8DD613EE for ; Sat, 8 May 2021 23:20:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229672AbhEHXVa (ORCPT ); Sat, 8 May 2021 19:21:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbhEHXV2 (ORCPT ); Sat, 8 May 2021 19:21:28 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9559C061573 for ; Sat, 8 May 2021 16:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MgGM9LaDhzqC2AUWraDRKJjmwAHl2LHVlB1VPC4+S+w=; b=HHideBd3E0a6pv3Cr6H1zLetvE P5c/OKmy5+xtQcVqDqs5FHRAhi6WBRCg4yrNjRFcTND4Y44mYPcEirPGw3LUVGH2aM15unXtBOm7r ybV4Hc1ASGae7IFSg2cDJIZ+7I18HWvCPQKWT+amufcWaFY3h1XU65JCKG0FMiLSfLWmCpoeRjflX uTWVjAc7P8qzUvu4cQ/bGgq0zZ50oVmjsOpyl5hsQ5I9ROZTHxZQtxS3jT1FyRLk826sVjswWs3s2 eueSYTwnhHKGsM+fSxW3RmiUq/Z2GIkhbjwruFLppyJw4a+PlHxesDECMNbqgQ1FWm5A9JEdCxbvz 3RQD9yhw==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lfWEW-004dVU-9G; Sat, 08 May 2021 23:19:43 +0000 Date: Sun, 9 May 2021 00:19:40 +0100 From: Matthew Wilcox To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: kmalloc_index: remove case when size is more than 32MB Message-ID: References: <20210508221328.7338-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210508221328.7338-1-42.hyeyoo@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 09, 2021 at 07:13:28AM +0900, Hyeonggon Yoo wrote: > the return value of kmalloc_index is used as index of kmalloc_caches, it doesn't matter. every few weeks somebody posts a patch to "optimise" kmalloc_index, failing to appreciate that it's only ever run at compile time because it's all under __builtin_constant_p().