From: Stafford Horne <shorne@gmail.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Mike Rapoport <rppt@linux.ibm.com>,
openrisc@lists.librecores.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] openrisc: mm/init.c: remove unused variable 'end' in paging_init()
Date: Mon, 10 May 2021 06:18:05 +0900 [thread overview]
Message-ID: <YJhRjTPdJbjI5iyj@antec> (raw)
In-Reply-To: <20210509091103.7985-3-rppt@kernel.org>
On Sun, May 09, 2021 at 12:11:03PM +0300, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
>
> A build with W=1 enabled produces the following warning:
>
> CC arch/openrisc/mm/init.o
> arch/openrisc/mm/init.c: In function 'paging_init':
> arch/openrisc/mm/init.c:131:16: warning: variable 'end' set but not used [-Wunused-but-set-variable]
> 131 | unsigned long end;
> | ^~~
>
> Remove the unused variable 'end'.
>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> arch/openrisc/mm/init.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/openrisc/mm/init.c b/arch/openrisc/mm/init.c
> index f3fa02b8838a..6e38ec96cab8 100644
> --- a/arch/openrisc/mm/init.c
> +++ b/arch/openrisc/mm/init.c
> @@ -128,7 +128,6 @@ void __init paging_init(void)
> {
> extern void tlb_init(void);
>
> - unsigned long end;
> int i;
>
> printk(KERN_INFO "Setting up paging and PTEs.\n");
> @@ -144,8 +143,6 @@ void __init paging_init(void)
> */
> current_pgd[smp_processor_id()] = init_mm.pgd;
>
> - end = (unsigned long)__va(max_low_pfn * PAGE_SIZE);
> -
> map_ram();
>
> zone_sizes_init();
Thanks, I will queue this in the openrisc fixes queue.
-Stafford
prev parent reply other threads:[~2021-05-09 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-09 9:11 [PATCH 0/2] openrisc: mm/init.c: fix compilation warnings Mike Rapoport
2021-05-09 9:11 ` [PATCH 1/2] openrisc: mm/init.c: remove unused memblock_region variable in map_ram() Mike Rapoport
2021-05-09 21:17 ` Stafford Horne
2021-05-09 9:11 ` [PATCH 2/2] openrisc: mm/init.c: remove unused variable 'end' in paging_init() Mike Rapoport
2021-05-09 21:18 ` Stafford Horne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJhRjTPdJbjI5iyj@antec \
--to=shorne@gmail.com \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=openrisc@lists.librecores.org \
--cc=rppt@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=stefan.kristiansson@saunalahti.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox