Re: [f2fs-dev] [PATCH v2] f2fs: reduce expensive checkpoint trigger frequency

Chao Yu
2021-05-07T06:53:19Z

On 2021/5/7 14:33, Eric Biggers wrote:
> On Sun, Apr 25, 2021 at 09:10:53AM +0800, Chao Yu wrote:
>> + if (!error && S_ISDIR(inode->i_mode) && f2fs_encrypted_file(inode) &&
>> + f2fs_is_checkpointed_node(sbi, inode->i_ino))
>> + f2fs_add_ino_entry(sbi, inode->i_ino, ENC_DIR_INO);
>
> This will never be true, since S_ISDIR() and f2fs_encrypted_file() are logically
> contradictory (as f2fs_encrypted_file() only returns true when S_ISREG()).
>
> How did you test this change?

I should add RFC tag in this v2 as v1, since I haven't test both
with specified case because this idea should be discussed first.

Thanks,

>
> - Eric
> .
>