From: Jarkko Sakkinen <jarkko@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Shuah Khan <shuah@kernel.org>,
linux-sgx@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
reinette.chatre@intel.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] selftests/sgx: Rename 'eenter' and 'sgx_call_vdso'
Date: Wed, 12 May 2021 04:14:04 +0300 [thread overview]
Message-ID: <YJsr3MWf55UWLCiO@kernel.org> (raw)
In-Reply-To: <4b8d9604-8d35-eefe-41cb-511b92a3f086@intel.com>
On Tue, May 11, 2021 at 11:49:18AM -0700, Dave Hansen wrote:
> On 5/7/21 8:56 PM, Jarkko Sakkinen wrote:
> > Rename symbols for better clarity:
> >
> > * 'eenter' -> 'vdso_sgx_enter_enclave'
> > * 'sgx_call_vdso' -> 'sgx_enter_enclave'
>
> Another sentence or two here would do wonders:
>
> 'eenter' might be confused for directly calling ENCLU[EENTER]. It does
> not. It calls into the VDSO, which actually has the EENTER instruction.
>
> 'sgx_call_vdso' is *only* used for entering the enclave. It's not some
> generic SGX call into the VDSO.
>
> Make the naming reflect that.
>
> Right?
Agreed.
I'll spin off a yet new version of the series, taking also care
of the log messages that the enclave loader emits (Renette's
feedback). They should be wrapped with TH_LOG() macro I suppose.
/Jarkko
prev parent reply other threads:[~2021-05-12 1:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 3:56 [PATCH v4 1/2] selftests/sgx: Rename 'eenter' and 'sgx_call_vdso' Jarkko Sakkinen
2021-05-08 3:56 ` [PATCH v4 2/2] selftests/sgx: Migrate to kselftest harness Jarkko Sakkinen
2021-05-11 18:42 ` Reinette Chatre
2021-05-12 1:10 ` Jarkko Sakkinen
2021-05-12 15:56 ` Reinette Chatre
2021-05-12 19:17 ` Jarkko Sakkinen
2021-05-11 18:49 ` [PATCH v4 1/2] selftests/sgx: Rename 'eenter' and 'sgx_call_vdso' Dave Hansen
2021-05-12 1:14 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJsr3MWf55UWLCiO@kernel.org \
--to=jarkko@kernel.org \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox