From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08C31C2B9F8 for ; Tue, 25 May 2021 14:36:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2F5C6142B for ; Tue, 25 May 2021 14:36:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234073AbhEYOhi (ORCPT ); Tue, 25 May 2021 10:37:38 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:49404 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234047AbhEYOhK (ORCPT ); Tue, 25 May 2021 10:37:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ki/UxVATrYCQetouX/QmwaQIst2UWIZZsnwpm15gHok=; b=oo9ObZfUthqW/IFjCDipZkNAxn y4Z1mRP6aPZgLGBUSXINQjADeUh0E0t2FsWhntgy2pQG7LLdpCwryPpuayZsTmEuFfqSCeSzgYIL+ 2SmyUja9Kj9v1V+JNCPRS1N9l3KTu9QbjFb+h+eLr89sE0qwjocN4TMXqVTowhaapaYI=; Received: from 94.196.90.140.threembb.co.uk ([94.196.90.140] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1llY9O-005lfK-EW; Tue, 25 May 2021 14:35:18 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 333F8D00B19; Tue, 25 May 2021 15:35:51 +0100 (BST) Date: Tue, 25 May 2021 15:35:51 +0100 From: Mark Brown To: Ralf Schlatterbeck Cc: Andre Przywara , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Mirko Vogt Subject: Re: [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug Message-ID: References: <20210520100656.rgkdexdvrddt3upy@runtux.com> <20210521173011.1c602682@slackpad.fritz.box> <20210521201913.2gapcmrzynxekro7@runtux.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eQZK+OgGNZ+kM+zd" Content-Disposition: inline In-Reply-To: <20210521201913.2gapcmrzynxekro7@runtux.com> X-Cookie: The wages of sin are unreported. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --eQZK+OgGNZ+kM+zd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 21, 2021 at 10:19:13PM +0200, Ralf Schlatterbeck wrote: > From: Mirko Vogt >=20 > The current sun6i SPI implementation initializes the transfer too early, > resulting in SCK going high before the transfer. When using an additional > (gpio) chipselect with sun6i, the chipselect is asserted at a time when > clock is high, making the SPI transfer fail. Please don't send new patches in reply to old threads, this makes it hard to follow what is going on and creates confusion as to what the current version of things is and means things can easily get missed if the earlier thread gets discarded - this goes along with the thing Andre mentioned about flagging the version of the patch in the subject line. --eQZK+OgGNZ+kM+zd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmCtC0YACgkQJNaLcl1U h9AY5QgAgcWYI2VA7WPTIjHk9SuXExgIBAH1SNcW2KwVRbBcesxqHH3Dzlfg9vqc C6luchIJ7CILJTdw5h1F4j3UhDtGEnQAyq5eecZ0la/eS5POfkWdObtdnWgW8qVj 9nddoYKV/goXt9jc4VqtOZSKdl9/yY3aK44xFvLZ3k2HJUSCBsr7aGuONUGVjX6Z uOYROLl4x6wKUugWfrLANl1PRZBf8fSUOa426DdpWpw+FkLWnaJLAKqQQT2YJPfQ vNBe4PjQ9Czqr/8R+FFBAgF005PHX6l/ek2A8lWZ/YuSZGM94qoPIHF5OYLpwSQZ x/6RCx9aCRKKd4rU1g9Mlobv8p4Zdg== =ZFjA -----END PGP SIGNATURE----- --eQZK+OgGNZ+kM+zd--