From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E01A7C2B9F7 for ; Wed, 26 May 2021 04:50:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B776A6138C for ; Wed, 26 May 2021 04:50:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229947AbhEZEwR (ORCPT ); Wed, 26 May 2021 00:52:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:37530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229604AbhEZEwO (ORCPT ); Wed, 26 May 2021 00:52:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BD33B6138C; Wed, 26 May 2021 04:50:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622004643; bh=xWZssZLzeeutnbtwx05LnJcWgG7rsPibYpQf/tb43JE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FULZA0ZuZUvdtLWim8eh0Y1evYUEFKESPHdKSs+ZgmA/TAiFi8asT+bT2XBiMQ6MO nRmbLMz5Q1xQfUju/40pJu5VZePnuS2N2UAtoNq3jaJYshdTgaUDsN0lxYmJcIjR3a F0SjPIo8uItnZUCO6MuDVTu/7Vifv6eRwfiVsLGDi3n9y+lPe+O2TaJwOPaHJ8hrDP 1BuergTPFwkvBVPeZRkTmITVELbOoyZ7Frh+AkjOc4ciRoId3ZojuNo8zz1bUoxMWY OwEHX79EuVTnQImKFOyYANtDe8/7b2BRtxtAub17NsTFIrSbjK+by+MNskdVqBownT DtHRQ8pNFDoYw== Date: Wed, 26 May 2021 07:50:40 +0300 From: Jarkko Sakkinen To: amirmizi6@gmail.com Cc: Eyal.Cohen@nuvoton.com, peterhuewe@gmx.de, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, Dan.Morav@nuvoton.com, oren.tanami@nuvoton.com, shmulik.hager@nuvoton.com, amir.mizinski@nuvoton.com Subject: Re: [PATCH v4] tpm2: add longer timeout for verify signature command Message-ID: References: <20210525111325.158790-1-amirmizi6@gmail.com> <20210525111325.158790-2-amirmizi6@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210525111325.158790-2-amirmizi6@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 25, 2021 at 02:13:25PM +0300, amirmizi6@gmail.com wrote: > From: Amir Mizinski > > While running a TPM2_CC_VERIFY_SIGNATURE operation with RSA 3072-bit > keys the TPM driver fails with the following error: > > "kernel: [ 2416.187522] tpm tpm0: Operation Timed out" > > Since the TPM PC Client specification does not specify a number for > verify signature operation timeout, and the duration of > TPM2_CC_VERIFY_SIGNATURE with RSA 3072-bit keys exceeds the current timeout > of TPM_LONG (2 seconds), it is preferable to pick the longest timeout > possible. > > Therefore, set the duration for TPM2_CC_VERIFY_SIGNATUE to TPM_LONG_LONG > (5 minutes). > > Link: https://trustedcomputinggroup.org/resource/pc-client-specific-platform-firmware-profile-specification/ > Signed-off-by: Amir Mizinski > --- Thank you. Reviewed-by: Jarkko Sakkinen /Jarkko