From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Trent Piepho <tpiepho@gmail.com>
Cc: linux-kernel@vger.kernel.org, andy@kernel.org,
akpm@linux-foundation.org, oskar@scara.com,
Daniel Latypov <dlatypov@google.com>,
Yiyuan Guo <yguoaz@gmail.com>
Subject: Re: [PATCH v3 1/2] lib/math/rational.c: Fix divide by zero
Date: Wed, 26 May 2021 11:06:34 +0300 [thread overview]
Message-ID: <YK4BiteKybO2qGHq@smile.fi.intel.com> (raw)
In-Reply-To: <YK4BDmPDuXfxEDn7@smile.fi.intel.com>
On Wed, May 26, 2021 at 11:04:30AM +0300, Andy Shevchenko wrote:
> On Tue, May 25, 2021 at 04:35:18PM -0700, Trent Piepho wrote:
> > If the input is out of the range of the allowed values, either larger
> > than the largest value or closer to zero than the smallest non-zero
> > allowed value, then a division by zero would occur.
> >
> > In the case of input too large, the division by zero will occur on the
> > first iteration. The best result (largest allowed value) will be found
> > by always choosing the semi-convergent and excluding the denominator
> > based limit when finding it.
> >
> > In the case of the input too small, the division by zero will occur on
> > the second iteration. The numerator based semi-convergent should not be
> > calculated to avoid the division by zero. But the semi-convergent vs
> > previous convergent test is still needed, which effectively chooses
> > between 0 (the previous convergent) vs the smallest allowed fraction
> > (best semi-convergent) as the result.
>
> What has been changed that you haven't applied my Rb tag?
Note, the `b4` tool can easily collect them for you from previous thread.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-05-26 8:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 23:35 [PATCH v3 1/2] lib/math/rational.c: Fix divide by zero Trent Piepho
2021-05-25 23:35 ` [PATCH v3 2/2] lib/math/rational: Add Kunit test cases Trent Piepho
2021-05-25 23:53 ` Daniel Latypov
2021-05-26 8:04 ` [PATCH v3 1/2] lib/math/rational.c: Fix divide by zero Andy Shevchenko
2021-05-26 8:06 ` Andy Shevchenko [this message]
2021-05-26 19:09 ` Trent Piepho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK4BiteKybO2qGHq@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=dlatypov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oskar@scara.com \
--cc=tpiepho@gmail.com \
--cc=yguoaz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox