Re: [PATCH v5 00/16] Allwinner MIPI CSI-2 support for A31/V3s/A83T

Sakari Ailus
2021-05-26T17:15:04Z

Hi Paul,

On Wed, May 26, 2021 at 03:28:20PM +0200, Paul Kocialkowski wrote:
> Hi,
>
> On Wed 26 May 21, 14:00, Hans Verkuil wrote:
> > Hi Paul,
> >
> > On 15/01/2021 21:01, Paul Kocialkowski wrote:
> > > This series introduces support for MIPI CSI-2, with the A31 controller that is
> > > found on most SoCs (A31, V3s and probably V5) as well as the A83T-specific
> > > controller. While the former uses the same MIPI D-PHY that is already supported
> > > for DSI, the latter embeds its own D-PHY.
> > >
> > > In order to distinguish the use of the D-PHY between Rx mode (for MIPI CSI-2)
> > > and Tx mode (for MIPI DSI), a submode is introduced for D-PHY in the PHY API.
> > > This allows adding Rx support in the A31 D-PHY driver.
> > >
> > > A few changes and fixes are applied to the A31 CSI controller driver, in order
> > > to support the MIPI CSI-2 use-case.
> >
> > Besides the compile error for patch 2/16, I also get several other compile errors:
> >
> > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c: In function ‘sun6i_csi_v4l2_fwnode_init’:
> > ./include/media/v4l2-async.h:207:10: error: expected expression before ‘)’ token
> > 207 | ((type *) \
> > | ^
> > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:790:8: note: in expansion of macro ‘v4l2_async_notifier_add_fwnode_remote_subdev’
> > 790 | ret = v4l2_async_notifier_add_fwnode_remote_subdev(&csi->notifier,
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > ./include/media/v4l2-async.h:207:10: error: expected expression before ‘)’ token
> > 207 | ((type *) \
> > | ^
> > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:811:8: note: in expansion of macro ‘v4l2_async_notifier_add_fwnode_remote_subdev’
> > 811 | ret = v4l2_async_notifier_add_fwnode_remote_subdev(&csi->notifier,
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > make[5]: *** [scripts/Makefile.build:272: drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.o] Error 1
> > make[5]: *** Waiting for unfinished jobs....
> > make[4]: *** [scripts/Makefile.build:272: drivers/media/platform/rockchip/rkisp1/rkisp1-isp.o] Error 1
> > make[3]: *** [scripts/Makefile.build:515: drivers/media/platform/rockchip/rkisp1] Error 2
> > make[3]: *** Waiting for unfinished jobs....
> > In file included from ./include/media/v4l2-subdev.h:14,
> > from ./include/media/v4l2-device.h:13,
> > from drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c:19:
> > drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c: In function ‘sun8i_a83t_mipi_csi2_v4l2_setup’:
> > ./include/media/v4l2-async.h:207:10: error: expected expression before ‘)’ token
> > 207 | ((type *) \
> > | ^
> > drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c:495:8: note: in expansion of macro
> > ‘v4l2_async_notifier_add_fwnode_remote_subdev’
> > 495 | ret = v4l2_async_notifier_add_fwnode_remote_subdev(notifier, handle,
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > In file included from ./include/media/v4l2-subdev.h:14,
> > from ./include/media/v4l2-device.h:13,
> > from drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:18:
> > drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c: In function ‘sun6i_mipi_csi2_v4l2_setup’:
> > ./include/media/v4l2-async.h:207:10: error: expected expression before ‘)’ token
> > 207 | ((type *) \
> > | ^
> > drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:437:8: note: in expansion of macro ‘v4l2_async_notifier_add_fwnode_remote_subdev’
> > 437 | ret = v4l2_async_notifier_add_fwnode_remote_subdev(notifier, handle,
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Can you rebase this series?
>
> Thanks for letting me know, I'll look into this for the next iteration.
>
> > I also need Acked-by's for patches 1-3 from one of the PHY maintainers, but as
> > you mentioned this might need to change as well.
> >
> > Was there a reason why I haven't looked at this before? It's quite an old series,
> > usually I don't wait for so long. If it was because I was really slow, then I
> > apologize and please kick me sooner if you see a review like this take so long.
>
> I'm not sure, but Sakari definitely went over previous interations and made
> various comments,so the series definitely hasn't gone unreviewed!

My acks seem to be missing. Let me go through it. As for Hans: please ping
if you don't get reviews.

--
Kind regards,

Sakari Ailus