From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC9ACC47089 for ; Thu, 27 May 2021 09:41:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF64F613F0 for ; Thu, 27 May 2021 09:41:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235947AbhE0JnA (ORCPT ); Thu, 27 May 2021 05:43:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:40886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235675AbhE0Jmy (ORCPT ); Thu, 27 May 2021 05:42:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1D4F1613E9; Thu, 27 May 2021 09:41:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1622108481; bh=4xVJXPa7VlFF52HmWIoRuIgF7KKFuNeS/i1lX4FoDlE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eH0PUMohDmqbgUkqLzeGPPawhTu7XvNI29tR/bmmkT/DmTiPQWk6v9oV6hy2Np0hR Of2z0DCqlqDu6pXjGDnleIikqaLA5ktTItS7G2JK7GjXX9k4jaySwqNOUF5R/vSjTT zXOEqrLOpglTrUAm2X7O3lT+ELslouFyjzOXezlg= Date: Thu, 27 May 2021 11:41:18 +0200 From: Greg KH To: Baokun Li Cc: rafael@kernel.org, linux-kernel@vger.kernel.org, weiyongjun1@huawei.com, yuehaibing@huawei.com, yangjihong1@huawei.com, yukuai3@huawei.com Subject: Re: [PATCH -next] driver core: Remove set but not used variable 'no_warn' Message-ID: References: <20210527091453.3880695-1-libaokun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210527091453.3880695-1-libaokun1@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 27, 2021 at 05:14:53PM +0800, Baokun Li wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/base/module.c: In function 'module_create_drivers_dir': > drivers/base/module.c:36:6: warning: > variable ‘no_warn’ set but not used [-Wunused-but-set-variable] > > It never used since introduction. > > Signed-off-by: Baokun Li > --- > drivers/base/module.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/base/module.c b/drivers/base/module.c > index 46ad4d636731..07ecd66b12b0 100644 > --- a/drivers/base/module.c > +++ b/drivers/base/module.c > @@ -33,7 +33,6 @@ static void module_create_drivers_dir(struct module_kobject *mk) > void module_add_driver(struct module *mod, struct device_driver *drv) > { > char *driver_name; > - int no_warn; > struct module_kobject *mk = NULL; > > if (!drv) > @@ -59,12 +58,12 @@ void module_add_driver(struct module *mod, struct device_driver *drv) > return; > > /* Don't check return codes; these calls are idempotent */ > - no_warn = sysfs_create_link(&drv->p->kobj, &mk->kobj, "module"); > + sysfs_create_link(&drv->p->kobj, &mk->kobj, "module"); > driver_name = make_driver_name(drv); > if (driver_name) { > module_create_drivers_dir(mk); > - no_warn = sysfs_create_link(mk->drivers_dir, &drv->p->kobj, > - driver_name); > + sysfs_create_link(mk->drivers_dir, &drv->p->kobj, > + driver_name); > kfree(driver_name); > } > } > -- > 2.25.4 > And now you have a build warning :( Please always test-build your patches before sending them out. greg k-h