From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F683C433B4 for ; Sat, 15 May 2021 23:52:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EA6161242 for ; Sat, 15 May 2021 23:52:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231659AbhEOXxh (ORCPT ); Sat, 15 May 2021 19:53:37 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:42222 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230102AbhEOXx2 (ORCPT ); Sat, 15 May 2021 19:53:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=RP7yGAEHZlhCRQ2Dd9FV88IXokX2WkuH4I1RMy1fDuA=; b=wmE93zq4qsXp62qUP9gyku4vin jJZ5XJx3eBfJfB1dYbWETZylRioIp9dgyqQsatqaSCftXhIU4+HTdr5eDsZIio8viOBLMjJW05pga sL60/Bdj4Qad7tSdU6eqXm+8M6pzA8wYotI/wVs0c1O2IT7szUa5hsEBbwvqoj+BZhgo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1li44j-004NOO-Q4; Sun, 16 May 2021 01:52:05 +0200 Date: Sun, 16 May 2021 01:52:05 +0200 From: Andrew Lunn To: Ansuel Smith Cc: Jonathan McDowell , Florian Fainelli , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH net-next v4 01/28] net: mdio: ipq8064: clean whitespaces in define Message-ID: References: <20210508002920.19945-1-ansuelsmth@gmail.com> <20210515170046.GA18069@earth.li> <20210515180856.GI11733@earth.li> <20210515194047.GJ11733@earth.li> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > They're on 2 separate sets of GPIOs if that makes a difference - switch0 > > is in gpio0/1 and switch1 is on gpio10/11. Is the internal MDIO logic > > shared between these? Also even if that's the case it seems odd that > > enabling the MDIO for just switch0 doesn't work? > > > > The dedicated internal mdio on ipq8064 is unique and present on the > gmac0 address so yes it's shared between them. And this seems to be the > problem... As you notice the fact that different gpio are used for the > different switch fix the problem. So think that to use the dedicated > mdio bus with both switch we need to introduce some type of > syncronization or something like that. Please could you describe the hardware in a bit more details. Or point me at a datasheet. It sounds like you have an MDIO mux? Linux has this concept, so you might need to implement a mux driver. Andrew