From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91687C43460 for ; Mon, 17 May 2021 13:55:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CA2C611BF for ; Mon, 17 May 2021 13:55:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235889AbhEQN4i (ORCPT ); Mon, 17 May 2021 09:56:38 -0400 Received: from mga14.intel.com ([192.55.52.115]:57324 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232924AbhEQN4h (ORCPT ); Mon, 17 May 2021 09:56:37 -0400 IronPort-SDR: 50HQd2RBXs2WDefU5PDrLMn3Hfxq2HSE2HS9tiEfiPiKyIczZGr1G8rnKxq4M5Z9+6X9k4pSFO +5Th9inZl/1A== X-IronPort-AV: E=McAfee;i="6200,9189,9986"; a="200158629" X-IronPort-AV: E=Sophos;i="5.82,307,1613462400"; d="scan'208";a="200158629" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2021 06:55:20 -0700 IronPort-SDR: fSvTIsGurRYgent6K79/Xss7RZBAXtHTtan8QeTT6bMNbdqDs74os5Lq6si6KvOPFhpRFikhlQ bQQOXRAWnvVQ== X-IronPort-AV: E=Sophos;i="5.82,307,1613462400"; d="scan'208";a="472415095" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2021 06:55:19 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lidiH-00CkQX-9r; Mon, 17 May 2021 16:55:17 +0300 Date: Mon, 17 May 2021 16:55:17 +0300 From: Andy Shevchenko To: Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Wolfram Sang Subject: Re: [PATCH v1 1/1] i2c: core: Make debug message even more debuggish Message-ID: References: <20210428145751.4934-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210428145751.4934-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 28, 2021 at 05:57:51PM +0300, Andy Shevchenko wrote: > One may notice that dev_printk(KERN_DEBUG ...) is *not* an equivalent > to dev_dbg(). It will be printed whenever loglevel is high enough. > And currently it will be the only message in the I²C core in some > configurations that got printed under above conditions. > > Moving to dev_dbg() will hide it in the configurations where Dynamic Debug > is enabled and hence align with all other debug messages in the I²C core.. Wolfram, any comment on this? -- With Best Regards, Andy Shevchenko