From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-kernel@vger.kernel.org, Rob Clark <robdclark@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h
Date: Mon, 17 May 2021 15:19:49 +0300 [thread overview]
Message-ID: <YKJfZXn3P/ZdslRP@smile.fi.intel.com> (raw)
In-Reply-To: <20210407122337.77493-1-andriy.shevchenko@linux.intel.com>
On Wed, Apr 07, 2021 at 03:23:37PM +0300, Andy Shevchenko wrote:
> The ascii85.h is user of exactly two headers, i.e. math.h and types.h.
> There is no need to carry on entire kernel.h.
It seems DRM has strict rules about what's going thru DRM tree and this one,
while being used only for DRM drivers and been originated as i915 code, in a
stale position right now.
Who can take it, please? (It's Rb by Jani)
I Cc'ed this to Andrew, if he is okay to expedite it, and to Rob, who is the
committer of the original move patch.
Personally to me DRM seems the best match, but... see above.
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/linux/ascii85.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/ascii85.h b/include/linux/ascii85.h
> index 4cc40201273e..83ad775ad0aa 100644
> --- a/include/linux/ascii85.h
> +++ b/include/linux/ascii85.h
> @@ -8,7 +8,8 @@
> #ifndef _ASCII85_H_
> #define _ASCII85_H_
>
> -#include <linux/kernel.h>
> +#include <linux/math.h>
> +#include <linux/types.h>
>
> #define ASCII85_BUFSZ 6
>
> --
> 2.30.2
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-05-17 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 12:23 [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h Andy Shevchenko
2021-04-07 12:46 ` Jani Nikula
2021-04-07 13:40 ` Andy Shevchenko
2021-04-07 13:41 ` Andy Shevchenko
2021-05-17 12:19 ` Andy Shevchenko [this message]
2021-05-17 12:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKJfZXn3P/ZdslRP@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox