* [PATCH] f2fs: add MODULE_SOFTDEP to ensure crc32c is included in the initramfs
@ 2021-05-17 1:15 Chao Yu
2021-05-17 17:27 ` [f2fs-dev] " Eric Biggers
0 siblings, 1 reply; 3+ messages in thread
From: Chao Yu @ 2021-05-17 1:15 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, chao, Chao Yu, marcosfrm
As marcosfrm reported in bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=213089
Initramfs generators rely on "pre" softdeps (and "depends") to include
additional required modules.
F2FS does not declare "pre: crc32" softdep. Then every generator (dracut,
mkinitcpio...) has to maintain a hardcoded list for this purpose.
Hence let's use MODULE_SOFTDEP("pre: crc32") in f2fs code.
Fixes: 43b6573bac95 ("f2fs: use cryptoapi crc32 functions")
Reported-by: marcosfrm <marcosfrm@gmail.com>
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
fs/f2fs/super.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 3f8a7a6c250c..fa0ce6301c16 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -4431,4 +4431,5 @@ module_exit(exit_f2fs_fs)
MODULE_AUTHOR("Samsung Electronics's Praesto Team");
MODULE_DESCRIPTION("Flash Friendly File System");
MODULE_LICENSE("GPL");
+MODULE_SOFTDEP("pre: crc32c");
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: add MODULE_SOFTDEP to ensure crc32c is included in the initramfs
2021-05-17 1:15 [PATCH] f2fs: add MODULE_SOFTDEP to ensure crc32c is included in the initramfs Chao Yu
@ 2021-05-17 17:27 ` Eric Biggers
2021-05-18 0:51 ` Chao Yu
0 siblings, 1 reply; 3+ messages in thread
From: Eric Biggers @ 2021-05-17 17:27 UTC (permalink / raw)
To: Chao Yu; +Cc: jaegeuk, marcosfrm, linux-kernel, linux-f2fs-devel
On Mon, May 17, 2021 at 09:15:57AM +0800, Chao Yu wrote:
> As marcosfrm reported in bugzilla:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=213089
>
> Initramfs generators rely on "pre" softdeps (and "depends") to include
> additional required modules.
>
> F2FS does not declare "pre: crc32" softdep. Then every generator (dracut,
> mkinitcpio...) has to maintain a hardcoded list for this purpose.
>
> Hence let's use MODULE_SOFTDEP("pre: crc32") in f2fs code.
>
> Fixes: 43b6573bac95 ("f2fs: use cryptoapi crc32 functions")
> Reported-by: marcosfrm <marcosfrm@gmail.com>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/super.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 3f8a7a6c250c..fa0ce6301c16 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -4431,4 +4431,5 @@ module_exit(exit_f2fs_fs)
> MODULE_AUTHOR("Samsung Electronics's Praesto Team");
> MODULE_DESCRIPTION("Flash Friendly File System");
> MODULE_LICENSE("GPL");
> +MODULE_SOFTDEP("pre: crc32c");
Shouldn't it be crc32, not crc32c?
- Eric
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: add MODULE_SOFTDEP to ensure crc32c is included in the initramfs
2021-05-17 17:27 ` [f2fs-dev] " Eric Biggers
@ 2021-05-18 0:51 ` Chao Yu
0 siblings, 0 replies; 3+ messages in thread
From: Chao Yu @ 2021-05-18 0:51 UTC (permalink / raw)
To: Eric Biggers; +Cc: jaegeuk, marcosfrm, linux-kernel, linux-f2fs-devel
On 2021/5/18 1:27, Eric Biggers wrote:
> On Mon, May 17, 2021 at 09:15:57AM +0800, Chao Yu wrote:
>> As marcosfrm reported in bugzilla:
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=213089
>>
>> Initramfs generators rely on "pre" softdeps (and "depends") to include
>> additional required modules.
>>
>> F2FS does not declare "pre: crc32" softdep. Then every generator (dracut,
>> mkinitcpio...) has to maintain a hardcoded list for this purpose.
>>
>> Hence let's use MODULE_SOFTDEP("pre: crc32") in f2fs code.
>>
>> Fixes: 43b6573bac95 ("f2fs: use cryptoapi crc32 functions")
>> Reported-by: marcosfrm <marcosfrm@gmail.com>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>> fs/f2fs/super.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>> index 3f8a7a6c250c..fa0ce6301c16 100644
>> --- a/fs/f2fs/super.c
>> +++ b/fs/f2fs/super.c
>> @@ -4431,4 +4431,5 @@ module_exit(exit_f2fs_fs)
>> MODULE_AUTHOR("Samsung Electronics's Praesto Team");
>> MODULE_DESCRIPTION("Flash Friendly File System");
>> MODULE_LICENSE("GPL");
>> +MODULE_SOFTDEP("pre: crc32c");
>
> Shouldn't it be crc32, not crc32c?
Thanks for the review, will fix.
Thanks,
>
> - Eric
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-18 0:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-17 1:15 [PATCH] f2fs: add MODULE_SOFTDEP to ensure crc32c is included in the initramfs Chao Yu
2021-05-17 17:27 ` [f2fs-dev] " Eric Biggers
2021-05-18 0:51 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox