From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0EB5C43460 for ; Mon, 17 May 2021 21:26:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77D2C6112D for ; Mon, 17 May 2021 21:26:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245103AbhEQV17 (ORCPT ); Mon, 17 May 2021 17:27:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237638AbhEQV16 (ORCPT ); Mon, 17 May 2021 17:27:58 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56A09C061756 for ; Mon, 17 May 2021 14:26:40 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id o17-20020a17090a9f91b029015cef5b3c50so334582pjp.4 for ; Mon, 17 May 2021 14:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Dhb1uTVRdTSDSDqMMsX7uuUg8xt1a4Se/9Ofk8WS2vY=; b=Y+CnDpzs3ikZKam2vkznv3FYm9jlSBtByhLjS+j+lNsS84Tnmcv0zsiaV0Uiuvf5T5 +G4u0N2NKEoRNYoggemPLimodzLgYMqH+Gl/i6aKozHmVoTiL0klsgLLkLPD6D8TzLhc E2FWpJAYDWCl0AHvdq/ZFcO1sGpglEMLu00uHxUHrhXkOVpvBB/zKcua7pGj+q4nVuq+ Pm9mOdDWTE2xLxb1KmAdzxqJCw6ssR82sKJiBrYGsUexh3LdytZCHRJa5B3YG+Dj/14c k51fwtedyZzgeLi/m8uDyquwXAELz874WwZ2ezpetcxXKsDCIWcWwSNHeW/qIKCB+juu mF3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Dhb1uTVRdTSDSDqMMsX7uuUg8xt1a4Se/9Ofk8WS2vY=; b=OniDXp4/yljedXQUJXRg/GYpyc0yXli+6y02KnuFb4gpsBBs5e9kvZ/4/GWTYNohGG gyYydFP2NvkCDWoHLog1B8XG8m2bz9V09zKt4w0iMVgV19RPAiAE4XocXpMbDqx16PTq LCNM0qMMW9i7h3V2Uh5H32L2TA4/dHprb28gcXw02gC7bFzKd1kjyxfGhLaD4vN2UMr7 DTCOcjmB/z3Znyuga3VwBrT3qnRB/kXxsZPNM9eRhx3aTkBm/137kaOREEmjgiP39KVW eni1sXwZnCaiGbbZSFV5aWNVHZ7/mXrMD1B6r9ijMVj3j3J8QRqpQR3RE/uGl/6W5pU9 5t0A== X-Gm-Message-State: AOAM530HdZW+pCl53ATHYjUkH3RzIRlJyCxsXP9ivheqd5TFK9sCcH5h CZRfOfV34Qf20dXznZsStOY9LA== X-Google-Smtp-Source: ABdhPJysVdDoDestSBDLBZRxY7hfIZLLWozeiiMqnT2Nf93oFJudVtNcA3f2Ij1/+l8OsbqXR2J8JQ== X-Received: by 2002:a17:90a:aa96:: with SMTP id l22mr1119473pjq.173.1621286799769; Mon, 17 May 2021 14:26:39 -0700 (PDT) Received: from google.com (240.111.247.35.bc.googleusercontent.com. [35.247.111.240]) by smtp.gmail.com with ESMTPSA id c191sm2637624pfc.94.2021.05.17.14.26.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 May 2021 14:26:39 -0700 (PDT) Date: Mon, 17 May 2021 21:26:35 +0000 From: Sean Christopherson To: Jim Mattson Cc: Vitaly Kuznetsov , kvm list , Paolo Bonzini , Wanpeng Li , Kechen Lu , Maxim Levitsky , LKML Subject: Re: [PATCH 1/2] KVM: x86: Invert APICv/AVIC enablement check Message-ID: References: <20210513113710.1740398-1-vkuznets@redhat.com> <20210513113710.1740398-2-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 17, 2021, Jim Mattson wrote: > On Mon, May 17, 2021 at 2:03 PM Sean Christopherson wrote: > > > > On Thu, May 13, 2021, Vitaly Kuznetsov wrote: > > > Currently, APICv/AVIC enablement is global ('enable_apicv' module parameter > > > for Intel, 'avic' module parameter for AMD) but there's no way to check > > > it from vendor-neutral code. Add 'apicv_supported()' to kvm_x86_ops and > > > invert kvm_apicv_init() (which now doesn't need to be called from arch- > > > specific code). > > > > Rather than add a new hook, just move the variable to x86.c, and export it so > > that VMX and SVM can give it different module names. The only hiccup is that > > avic is off by default, but I don't see why that can't be changed. > > See https://www.spinics.net/lists/kvm/msg208722.html. Boo. A common enable_apicv can still work, SVM just needs an intermediary between the module param and enable_apicv. --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -185,6 +185,10 @@ module_param(vls, int, 0444); static int vgif = true; module_param(vgif, int, 0444); +/* enable / disable AVIC */ +static bool avic; +module_param(avic, bool, S_IRUGO); + bool __read_mostly dump_invalid_vmcb; module_param(dump_invalid_vmcb, bool, 0644); @@ -1009,16 +1013,19 @@ static __init int svm_hardware_setup(void) nrips = false; } - if (avic) { - if (!npt_enabled || - !boot_cpu_has(X86_FEATURE_AVIC) || - !IS_ENABLED(CONFIG_X86_LOCAL_APIC)) { - avic = false; - } else { - pr_info("AVIC enabled\n"); + if (!npt_enabled || !boot_cpu_has(X86_FEATURE_AVIC)) + avic = false; - amd_iommu_register_ga_log_notifier(&avic_ga_log_notifier); - } + /* + * Override the common enable_apicv. AVIC is disabled by default + * because Jim said so. + */ + enable_apicv = avic; + + if (enable_apicv) { + pr_info("AVIC enabled\n"); + + amd_iommu_register_ga_log_notifier(&avic_ga_log_notifier); } if (vls) {