From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA831C433ED for ; Wed, 19 May 2021 08:31:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9466F60230 for ; Wed, 19 May 2021 08:31:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242152AbhESIdJ (ORCPT ); Wed, 19 May 2021 04:33:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:54798 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236249AbhESIdH (ORCPT ); Wed, 19 May 2021 04:33:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7EF3561355; Wed, 19 May 2021 08:31:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621413106; bh=44k6xIJijGFNay+2T/qkyD1nvLUD1zJTY/C3KnNuYV4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OrZ5gfn2PuBpGluKGxj5sZDRstijAVsuNrF8lkX9IKlLwweZWBahhkdjXVYA7YKfc HZQ+OzKUX19SnvrdniBX39lL2V8wHTxz5PNqbmLkqH3DIpT8rotB+VhROyMb2QJ/z/ whCzX6CFumrpba7fIfIN7Vky/wmnp+jWsA/+oRMo= Date: Wed, 19 May 2021 10:31:44 +0200 From: Greg Kroah-Hartman To: Hriday Hegde Cc: Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Hridya Valsaraju , Suren Baghdasaryan , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] staging: android: ashmem: Declared file operation with 'const' keyword Message-ID: References: <20210519081958.7223-1-hridayhegde1999@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210519081958.7223-1-hridayhegde1999@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 19, 2021 at 01:19:58AM -0700, Hriday Hegde wrote: > Fixing following warnings found by checkpatch.pl > WARNING: struct file_operations should normally be const > 380: FILE: drivers/staging/android/ashmem.c:380: > + static struct file_operations vmfile_fops; > > Signed-off-by: Hriday Hegde > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c > index 8ee4320a5dc6..8ff2794b08e3 100644 > --- a/drivers/staging/android/ashmem.c > +++ b/drivers/staging/android/ashmem.c > @@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, > > static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) > { > - static struct file_operations vmfile_fops; > + static const struct file_operations vmfile_fops; > struct ashmem_area *asma = file->private_data; > int ret = 0; > > -- > 2.25.1 > > Any reason why you didn't build your change before submitting this patch? thanks, greg k-h