From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
Suleiman Souhlal <suleiman@google.com>,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu/tree: consider time a VM was suspended
Date: Thu, 20 May 2021 14:50:49 +0900 [thread overview]
Message-ID: <YKX4ueNIabfd1DAD@google.com> (raw)
In-Reply-To: <20210518231514.GS4441@paulmck-ThinkPad-P17-Gen-1>
On (21/05/18 16:15), Paul E. McKenney wrote:
>
> In the shorter term... PVCLOCK_GUEST_STOPPED is mostly for things like
> guest migration and debugger breakpoints, correct?
Our use case is a bit different. We suspend VM when user puts the host
system into sleep (which can happen multiple times a day).
> Either way, I am wondering if rcu_cpu_stall_reset() should take a lighter
> touch. Right now, it effectively disables all stalls for the current grace
> period. Why not make it restart the stall timeout when the stoppage is detected?
Sounds good. I can cook a patch and run some tests.
Or do you want to send a patch?
> The strange thing is that unless something is updating the jiffies counter
> to make it look like the system was up during the stoppage time interval,
> there should be no reason to tell RCU anything. Is the jiffies counter
> updated in this manner? (Not seeing it right offhand, but I don't claim
> to be familiar with this code.)
VCPUs are not resumed all at once. It's up to the host to schedule VCPUs
for execution. So, for example, when we resume VCPU-3 and it discovers
this_cpu PVCLOCK_GUEST_STOPPED, other VCPUs, e.g. VCPU-0, can already be
resumed, up and running processing timer interrupts and adding ticks to
jiffies.
I can reproduce it.
While VCPU-2 has PVCLOCK_GUEST_STOPPED set (resuming) and is in
check_cpu_stall(), the VCPU-3 is executing:
apic_timer_interrupt()
tick_irq_enter()
tick_do_update_jiffies64()
do_timer()
next prev parent reply other threads:[~2021-05-20 5:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 10:27 [PATCH] rcu/tree: consider time a VM was suspended Sergey Senozhatsky
2021-05-17 16:23 ` Paul E. McKenney
2021-05-18 1:41 ` Sergey Senozhatsky
2021-05-18 23:15 ` Paul E. McKenney
2021-05-20 5:50 ` Sergey Senozhatsky [this message]
2021-05-20 14:57 ` Paul E. McKenney
2021-05-20 22:34 ` Sergey Senozhatsky
2021-05-21 0:15 ` Paul E. McKenney
2021-05-20 6:18 ` Sergey Senozhatsky
2021-05-20 14:53 ` Paul E. McKenney
2021-05-20 22:24 ` Sergey Senozhatsky
2021-05-21 0:14 ` Paul E. McKenney
2021-05-21 6:42 ` Sergey Senozhatsky
2021-05-21 14:02 ` Paul E. McKenney
2021-05-21 6:36 ` Sergey Senozhatsky
2021-05-21 14:01 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKX4ueNIabfd1DAD@google.com \
--to=senozhatsky@chromium.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=suleiman@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).