From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB33EC433B4 for ; Thu, 20 May 2021 18:00:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9974160C3F for ; Thu, 20 May 2021 18:00:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236181AbhETSCM (ORCPT ); Thu, 20 May 2021 14:02:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:54466 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235935AbhETSCK (ORCPT ); Thu, 20 May 2021 14:02:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4F5FE6100A; Thu, 20 May 2021 18:00:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621533649; bh=mVnDGgo84rltStTe6qWC9wFPh9rBe38XIaiFuc6M2tI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rH7GYEQdN0UV4tCNEGk5ci1eVo67dyHvWSMkwWhu6em0+V4qfutC8HBoAuKmnbWIO vHodrxI13FvfkvlSbPf1c/gXS/zpaJsWyVi2DEIQbhlE+Q0/I19GtxSx3iVLievN6l hV27vpxI2JvPHVT2LtFqtxwDZ6R9e8chTwC16+ks= Date: Thu, 20 May 2021 20:00:45 +0200 From: Greg Kroah-Hartman To: Hriday Hegde Cc: Alex Dewar , Sean Behan , Colin Ian King , Kumar Kartikeya Dwivedi , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: emxx_udc: Fixed coding style in places where lines should not end in '(' Message-ID: References: <20210520174701.8370-1-hridayhegde1999@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210520174701.8370-1-hridayhegde1999@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 20, 2021 at 10:46:57AM -0700, Hriday Hegde wrote: > The fixes were for the following checkpatch outputs: > > CHECK: Lines should not end with a '(' > 1076: FILE: drivers/staging/emxx_udc/emxx_udc.c:1076: > + _nbu2ss_writel( > > CHECK: Lines should not end with a '(' > 1228: FILE: drivers/staging/emxx_udc/emxx_udc.c:1228: > + length = _nbu2ss_readl( > > CHECK: Lines should not end with a '(' > 1465: FILE: drivers/staging/emxx_udc/emxx_udc.c:1465: > + regdata = _nbu2ss_readl( > > Signed-off-by: Hriday Hegde > --- > drivers/staging/emxx_udc/emxx_udc.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c > index 741147a4f0fe..8364316c1d25 100644 > --- a/drivers/staging/emxx_udc/emxx_udc.c > +++ b/drivers/staging/emxx_udc/emxx_udc.c > @@ -1073,8 +1073,8 @@ static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep, > i_word_length = length / sizeof(u32); > if (i_word_length > 0) { > for (i = 0; i < i_word_length; i++) { > - _nbu2ss_writel( > - &preg->EP_REGS[ep->epnum - 1].EP_WRITE, > + _nbu2ss_writel(&preg->EP_REGS[ep->epnum - 1] > + .EP_WRITE, Please don't break the line at ".", that makes this really hard to follow. thanks, greg k-h