From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 073CDC4707D for ; Fri, 21 May 2021 20:10:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D819B61183 for ; Fri, 21 May 2021 20:10:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229890AbhEUULn (ORCPT ); Fri, 21 May 2021 16:11:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:49388 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbhEUULl (ORCPT ); Fri, 21 May 2021 16:11:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AAC936101B; Fri, 21 May 2021 20:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621627818; bh=XA1ABq8YonEMJwPvBO1DQSpN/DaawZg01skDnn4XKy0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nk8p/uRVoQkyXFgDNR3qCjnQE3Bc3RDtc44yobAR7eEX26P3DvPkcprq7rX6f9sSz 9dmXDru2OE3+EFy8xhMU8Q4q6SPqn+CpFGE7RuBE9tjbDg53+shoN/sNU7g/n5T7j/ tpUiBSQV6ZZwXOerVMQULr9rIlbBmwl685ScmC90= Date: Fri, 21 May 2021 22:10:15 +0200 From: Greg Kroah-Hartman To: Rajat Jain Cc: "Rafael J. Wysocki" , Bjorn Helgaas , Alan Stern , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-usb@vger.kernel.org, helgaas@kernel.org, Oliver Neukum , David Laight , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , rajatxjain@gmail.com, jsbarnes@google.com, dtor@google.com Subject: Re: [PATCH v4 1/2] driver core: Move the "removable" attribute from USB to core Message-ID: References: <20210513232701.411773-1-rajatja@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210513232701.411773-1-rajatja@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 13, 2021 at 04:27:00PM -0700, Rajat Jain wrote: > Move the "removable" attribute from USB to core in order to allow it to be > supported by other subsystem / buses. Individual buses that want to support > this attribute can populate the removable property of the device while > enumerating it with the 3 possible values - > - "unknown" > - "fixed" > - "removable" > Leaving the field unchanged (i.e. "not supported") would mean that the > attribute would not show up in sysfs for that device. The UAPI (location, > symantics etc) for the attribute remains unchanged. > > Signed-off-by: Rajat Jain > --- > v4: - instead of devicce_type->supports_removable, add 1 more value in > device_removable_enum > - documentation update. > - Remove "Acked-by" and "Reviewed-by" tags from previous versions. > v3: - Minor commit log / comments updated. > - use sysfs_emit() > - Rename local variable name (state -> loc) > - change supports_removable flag from bool to bitfield. > v2: Add documentation This looks good to me, I have no further objection to it at all, nice cleanups. I can take this in my driver-core tree, so that other busses can use it (and can create a tag to pull from if needed), or I can also take the PCI patch (patch 2/2 here), if Bjorn gives his reviewed-by: for it. Are there other busses besides PCI that you want to enable this soon (i.e. before 5.14-rc1)? thanks, greg k-h