Re: [RFC PATCH 1/1] MAINTAINERS: TTY LAYER: add some ./include/linux/ header files

Jiri Slaby
2021-05-18T05:37:48Z

On 18. 05. 21, 7:21, Lukas Bulwahn wrote:
> An early prototypical automated code analysis of headers and the
> existing MAINTAINERS sections identified some header files in
> ./include/linux/ to be probably included into the TTY LAYER section.
>
> I further checked those suggestions by this analysis and identified a
> subset of files that I am rather certain to belong to the TTY LAYER.
>
> Add these ./include/linux/ header files to TTY LAYER in MAINTAINERS.
>
> The patterns include/linux/tty*.h and include/linux/vt_*.h currently cover:
>
> include/linux/tty.h
> include/linux/tty_driver.h
> include/linux/tty_flip.h
> include/linux/tty_ldisc.h
>
> include/linux/vt_buffer.h
> include/linux/vt_kern.h

Yes, that looks good.

Can you extend the tool to include/uapi too?

For example this is missing too:
include/uapi/linux/tty*.h

It expands to:
include/uapi/linux/tty_flags.h
include/uapi/linux/tty.h

> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> applies cleanly on next-20210507
>
> MAINTAINERS | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8923f0064784..d056f777c1a5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18563,9 +18563,13 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> F: Documentation/driver-api/serial/
> F: drivers/tty/
> F: drivers/tty/serial/serial_core.c
> +F: include/linux/selection.h
> F: include/linux/serial.h
> F: include/linux/serial_core.h
> -F: include/linux/tty.h
> +F: include/linux/sysrq.h
> +F: include/linux/tty*.h
> +F: include/linux/vt.h
> +F: include/linux/vt_*.h
> F: include/uapi/linux/serial.h
> F: include/uapi/linux/serial_core.h
> F: include/uapi/linux/tty.h
>

thanks,
--
js
suse labs